[colbymchenry]

What was wrong

A TypeScript field or local set from a dependency-injection call had no type, so calls through it linked nowhere, or to whichever class had a method of that name:

// Angular (bitwarden, ghostfolio)
private readonly dataService = inject(DataService);
protected params = inject<DialogParams>(DIALOG_DATA);
// vscode
private readonly widget = this._register(this.instantiationService.createInstance(Widget, …));
const service = instantiationService.createInstance(CustomizationMarketplaceWorkbenchService, …);

#2647 read this._register(new X()) fields and #2656 made a known class's call walk its supertypes, but neither covered an injector. A census on main counted 410 createInstance fields and 764 locals in vscode, 2,351 inject(X) fields in bitwarden and 587 in ghostfolio.

A related gap: a type the file imports under another name was looked up by its local name. bitwarden writes import { OrganizationApiServiceAbstraction as OrganizationApiService } and export { MessageSender as MessagingService }, and vscode writes import { Engine as FileSearchEngine }. Each call through such a value reached a class that happened to have the local name.

What changed (src/resolution/name-matcher.ts)

• Field reader: two new field patterns.
  • x = inject(X) and x = inject<T>(TOKEN). The type argument wins when there is one.
  • x = this.….createInstance(X, …), alone or inside a pass-through wrapper (this._register(…), this._store.add(…)).
• Validation: an injector counts only when it really hands back an instance of what it is given.
  • inject must be imported from @angular/core. Vue's inject(key) returns whatever was provided under the key.
  • createInstance must be declared somewhere in the project with InstanceType< in its signature, as vscode's IInstantiationService declares it.
  • The existing wrapper check still applies.
• Locals: the TS local patterns read const x = inject(X), inject<T>(…) and ….createInstance(X, …).
  • A local set from a member of what the injector returns (createInstance(Accessor).widget) isn't read as the class.
  • As before, a local's call counts only when the class has the method.
• Renaming imports: tsKnownTypeCall now finds a type the file imports under another name through that import (tsNamedType), when the name isn't declared under itself in the imported file.

Tests

• New __tests__/ts-injected-receivers.test.ts (5 tests):
  • Angular inject(X) fields and locals, including inject(X, { optional: true });
  • inject<T>(TOKEN);
  • Vue's inject is not read;
  • vscode createInstance fields, wrapped fields and locals, and a member of the created instance;
  • a createInstance the project doesn't declare with InstanceType is not read.
• One more test in __tests__/ts-known-class-methods.test.ts covers the renaming import.
• All of these are red on main.
• Full suite on this branch, rebased onto main 93f85d1, with the native kernel: 7,431 passed, 0 failed, 80 skipped.

A/B: fresh index, main 383c2cd vs this branch (since then, main has only gained #2660, which changes Go imports)

• vscode: nodes and files are identical.
  • 594 call sites gain a link.
  • 351 sites retarget to the class the injector is given or the renaming import names. 207 of these were 0.65 name guesses. 26 had reached another app's class; 5 still do, all in Copilot's simulation fixtures, which are copies of vscode files that import vscode's classes. The largest groups:
    • FileSearchEngine::search → Engine::search (32);
    • IJSONEditingService::write → JSONEditingService::write (20);
    • AskAgentProvider → PlanAgentProvider::provideCustomAgents (19);
    • IClaudeAgentSdkService::query → the created marketplace services' query (28).
  • 677 sites keep their target with a higher confidence: a name guess becomes the known class.
  • None are removed.
• bitwarden:
  • 1,835 call sites gain a link, mostly calls on inject(X) fields.
  • 35 retarget: a browser-app I18nService::t becomes the imported TranslationService::t, ElectronMainMessagingService::send becomes MessageSender::send through the renaming re-export, concrete services become the abstractions their files import under the concrete name, and inject(BrowserRouterService) reaches the browser router.
  • 69 keep their target with a higher confidence.
  • 3 are removed: router.navigate on Angular's inject(Router), which had been guessed as a project class's navigate.
• ghostfolio: 277 call sites gain a link, all on inject(X) fields.
• 8 other JS/TS repos (folo, vben, milo-ui, infrahub, medusa, react-native, refine-examples, excalidraw): byte-identical.

🤖 Generated with Claude Code