[colbymchenry]

What

This is the follow-up #2639 left open. TypeScript/JavaScript receiver inference reads a local or parameter annotated as one of a type's properties (editor: IChatWidget['inputEditor']) as the type it indexes (IChatWidget). The call then links to that type's method of the same name. If the type has no such method, the call falls through to a guess by the method's name.

On a fresh vscode index (main 10e316d), each case checked against its declaration:

• visibility.isVisible(…) with visibility: ISessionChatPillVisibilityService['pullRequests'] links to the service's own isVisible.
• raw.disconnect() through CopilotSessionWrapper['session'] links to the wrapper's disconnect.
• chatModel.onDidChange(…) with chatModel: IInlineChatSession['chatModel'] reaches HiddenRangeModel.onDidChange (a folding model), by the method's name alone.
• editor.executeEdits(…) and editor.getValue() with editor: IChatWidget['inputEditor'] (×11) reach ICodeEditor only by a 0.65 name guess.

Decision

The options I measured:

• (a) The type it indexes, as main does: the wrong links above.
• (b) Unknown, so name strategies decide: 30 new 0.65 guesses on vscode, some into test fixtures.
• (c) No type and no guess: drops the 11 editor.* guesses that happen to be right.
• (d) The type the property is declared with: that is what the annotation means. This PR does (d) when that type is written, and falls back to (a) when it isn't.

(d) reads the property with tsFieldDeclaration, the same reader this.<field>.<method>() calls use (#1496). It treats the result the way matchTsThisFieldCall does: the call links to that type's method, or to nothing. It is not matched by the method's name. A first version that fell through to the name strategies gave a wrong 0.65 guess for a property declared as an intersection.

Fix

In matchMethodCall's bracket-suffix block (#2639), an indexed type T['p'] / T["p"] goes through tsIndexedPropertyType:

• The indexed type T is the class or interface the call's file imports, or else declares (tsImportedTypeFile, fix(ts): a typed call links to the method of the class the file imports #2641). Its property p's declared type is read with tsFieldDeclaration.
• That type's class is the one the file declaring p imports, or else declares, passed to resolveMethodOnType as fix(ts): a typed call links to the method of the class the file imports #2641's hint. This takes vscode's disposables: ComponentFixtureContext['disposableStore'] to vscode's DisposableStore, where index order took copilot's vendored copy.
• A property declared as an array (groupIds: string[]) follows fix(ts): an array method on a local annotated as an array of a class links to nothing, not the class's method #2639's array rules. tsFieldDeclaration now reports a [] after the type.
• When the property's type is read, the method resolves on it at 0.9 instance-method, with no name fallback.
• When it isn't written there, the annotation is read as the type it indexes, as on main. That covers a getter, a typeof, a type parameter of the class, or a key that isn't a name (Parameters<typeof f>[0]).

Why the fallback matters: vscode's terminal test has let onCommandExecuted: Emitter<E>. Inference reads the nearer type-literal member let mockPty: { onCommandExecuted: Emitter<E>['event'] } instead. event is a getter of Emitter, and the field reader takes the event: T of fire(event: T) for it. Reading that as the class's type parameter T, and so deciding alone, cost 18 onCommandExecuted.fire / onCommandFinished.fire links that #2641 made correct.

I also tried skipping such type-literal members as declarations. On vscode that retargeted 888 calls and added and removed about 140 more, many of them wrong. Member lines are often what types a destructured local (const { service } = createService(…)), and the backward scan isn't scoped, so skipping them reaches unrelated declarations further up a test file. It's reverted.

Sync parking is unchanged from main. A failed indexed-type call still waits under the module of the type it indexes, where the property and its type are declared, so a change there re-opens it. One case isn't covered: a method added later to the property's type, in another module, doesn't re-open the call.

Validation

Fresh-index A/B vs main 10e316d

vscode (15,358 files): nodes and files are identical, and no name_tail changes. 14 edges removed and 12 added, all calls instance-method:

• 11 editor.* calls go from 0.65 name guesses to 0.9 typed links, with the same ICodeEditor targets.
• visibility.isVisible, raw.disconnect and chatModel.onDidChange, the wrong links above, are removed.
• disposables.add now links to vscode's vs/base/common/lifecycle DisposableStore.
• The 18 onCommand*.fire links are unchanged.

10 JS/TS repos (folo, vben, milo-ui, ghostfolio, infrahub, bitwarden, medusa, react-native, refine-examples, excalidraw): byte-identical.

Tests

__tests__/ts-array-annotated-receivers.test.ts's indexed-type describe has 8 tests.

Failing on main (run in a detached worktree):

• ed: Widget['inputEditor'] links ed.executeEdits to CodeEditor.executeEdits, with a DiffEditor.executeEdits decoy;
• visibility: VisibilityService['pullRequests'] links to Visibility.isVisible, not the service's own isVisible;
• a property declared as Filter & { isVisible(): boolean } gets no edge, neither the service's method nor a guess;
• groupIds: Element['groupIds'] on a string[] property gets no Element.filter edge;
• two widgets whose property files import different same-named CodeEditors each reach their own;
• two same-named Widgets, imported (once as import type) by two callers, each read their own property and reach the CodeEditor declared beside them.

Guards, which pass on main:

• logger: Parameters<typeof make>[0] gets no Logger.info name guess;
• onDone: Emitter<number>['event'], a getter's, with fire(event: T), still reaches Emitter.fire. This one fails without the fallback.

Mutations:

• reading the property off any same-named class first fails the import test;
• passing no hint, or only the declaring file, fails the import tests;
• falling through to name guesses fails the Parameters guard;
• a name fallback instead of exclusivity fails the intersection test;
• dropping the type-parameter rule fails the getter case.

Full suite (Windows), run while another heavy program was loading the machine: 573 files passed. 50 tests in 22 files failed, all 5 s timeouts except:

• the daemon-pid-reuse EBUSY teardown;
• a mcp-writer-lock race;
• the MPEG-TS indexing-time check;
• an EEXIST on a symlink root-identity.test.ts creates.

All 22 files pass when rerun serially (1,113 tests).

🤖 Generated with Claude Code