Skip to content

fix(bot): honor delays after gotoFlow #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-thakkar7 wants to merge 1 commit into
base: builderbot
Choose a base branch
from
Open

fix(bot): honor delays after gotoFlow #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/bot/__tests__/e2e/0.0.2-goto-flow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,19 @@ testSuite('Debe de continuar el el encadenamiento con procesos async', async ({

//Issue https://github.com/codigoencasa/bot-whatsapp/issues/877
testSuite('Debe respectar el delay del node previo', async ({ database, provider }) => {
const sentAt: number[] = []
provider.sendMessage = async () => {
sentAt.push(Date.now())
}

const flowPing = addKeyword(['hi']).addAction(async (_, { flowDynamic, gotoFlow }) => {
await flowDynamic('Buenas ping debe espera 1segundo')
return gotoFlow(flowBye)
})

const flowBye = addKeyword('ping').addAnswer(`Pong con delay 1 segundo`, { delay: 1000 })
const flowBye = addKeyword('ping')
.addAnswer(`Pong con delay 1 segundo`, { delay: 1000 })
.addAnswer(`Segundo pong con delay 1 segundo`, { delay: 1000 })

await createBot({
database,
Expand All @@ -256,11 +263,14 @@ testSuite('Debe respectar el delay del node previo', async ({ database, provider
body: 'hi',
})

await delay(2000)
await delay(3000)
const history = parseAnswers(database.listHistory).map((item) => item.answer)
assert.is('Buenas ping debe espera 1segundo', history[0])
assert.is('Pong con delay 1 segundo', history[1])
assert.is(undefined, history[2])
assert.is('Segundo pong con delay 1 segundo', history[2])
assert.is(undefined, history[3])
assert.ok(sentAt[1] - sentAt[0] >= 800, 'gotoFlow debe esperar el delay de la primera respuesta')
assert.ok(sentAt[2] - sentAt[1] >= 800, 'gotoFlow debe esperar el delay entre respuestas')
})

testSuite.run()
4 changes: 2 additions & 2 deletions packages/bot/src/core/coreClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,6 @@ class CoreClass<P extends ProviderClass = any, D extends MemoryDB = any> extends
return
}

await delay(flowInstance?.ctx?.options?.delay ?? 0)

const flowTree = flowInstance.toJson()

const flowParentId = flowTree[step]
Expand All @@ -446,6 +444,8 @@ class CoreClass<P extends ProviderClass = any, D extends MemoryDB = any> extends
const msgParse = this.flowClass.findSerializeByRef(msg?.ref)

const ctxMessage: TContext = { ...msgParse, ...msg }
const delayMs = ctxMessage?.options?.delay ?? this.generalArgs.delay ?? 0
await delay(delayMs)
await this.sendProviderAndSave(from, ctxMessage).then(() => promises.push(ctxMessage))
}

Expand Down