Repository navigation
refactor(data): raw_poly_vector launders its array pointers - #15
Merged
Merged
Conversation
Resolves the TEMP in raw_poly_vector::data(): std::start_lifetime_as_array needs the element count, which data() does not know. realloc() knows it and starts the lifetime of each array once, data() launders the pointer to the started array.
::operator new implicitly creates objects of implicit lifetime types in the returned storage, start_lifetime_as_array is not needed. It is also missing in the MSVC STL on clang (microsoft/STL GH-6169).
codethinki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
// TEMP use std::start_lifetime_as_arrayinraw_poly_vector::data().::operator new, which implicitly creates objects of implicit lifetime types ([intro.object]), so the arrays already existdata<I>()returnsstd::launderof the pointer instead of the plainreinterpret_caststd::start_lifetime_as_arrayis not needed here. The first version used it: the MSVC STL only declares it for the MSVC compiler (TRANSITION, GH-6169, clang lacks__builtin_start_lifetime_as_array), so Windows clang failed.Tested locally with gcc 16 and clang 23 (gcc_debug, clang_debug, gcc_release, clang_release: 263/263 tests).