Repository navigation
refactor: not_null constexpr in debug builds - #13
Merged
Merged
Conversation
The constructor and checkVal were constexpr in release builds only (CTH_RELEASE_CONSTEXPR). In constant evaluation the CTH_CRITICAL check only runs its failure branch for a null value, so a valid value evaluates at compile time and a null value is a compile error. CTH_RELEASE_CONSTEXPR had no other use and is removed, the cthm copy too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not_null's constructor andcheckValwere constexpr in release builds only (CTH_RELEASE_CONSTEXPR).In constant evaluation the
CTH_CRITICALcheck only runs its failure branch for a null value:CTH_CRITICALline, at run time debug builds still abortCTH_RELEASE_CONSTEXPRhad no other use and is removed.Tested locally with gcc 16 and clang 23 (gcc_debug, clang_debug, gcc_release, clang_release: 264/264 tests).
New test
not_null.constexprbuilds and copies anot_nullin astatic_assert.MSVC is only covered by the Windows CI.