Repository navigation
feat(utility): add reconstruct_at - #12
Closed
codethinki wants to merge 1 commit into
Closed
codethinki wants to merge 1 commit into
codethinki wants to merge 1 commit into
Conversation
Destroys the object at a location and move constructs it from other in place, like std::destroy_at and std::construct_at. For move assignment operators of types where = default leaks a resource.
Owner
Author
|
Not merging: move assignment through destroy + reconstruct in place is UB on base class subobjects, too easy to misuse. cth_engine uses std::unique_ptr with a deleter that holds the destroy context instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cth::reconstruct_at(object, std::move(other))destroysobjectand move constructs it fromotherin place. It is a move assignment for types where= defaultis wrong, e.g. types that own a resource throughcth::move_ptr, whose move assignment overwrites without destroying:noexcept: requires a nothrow move constructor and destructor, a throw after the destruction would leave a dead objectstd::destroy_atwould run the most derived destructorobjectis not a base class subobject or[[no_unique_address]]member, and does not ownothercth_engine uses it for its Vulkan handle classes.