Repository navigation
test: error-path e2e, and a race fix in the slow-pipe tests - #8
Merged
Merged
Conversation
… slow reader - e2e: bad API key (401) and unknown model (400) end as status failed, exit 1, with the reason; a failing tool (exit 7) and malformed tool arguments come back as tool results and the run goes on - slow-pipe tests attach the reader before pausing: a child that exited while the stream was paused lost its output to Node's flushStdio (3 in 20 runs under load with a fast-exiting CLI); a mutation back to process.exit() still fails them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test improvements from the (cancelled) native-binary experiment. No runtime change.
failed, exit 1, and the reason. A failing tool (exit 7) and malformed tool arguments must come back as tool results, and the run goes on. A crash, an empty stdout or a silent success fails the test.datalistener before pausing. If the child exits while the stream is paused with no listener, Node'sflushStdioresumes it and drops the data. A CLI that exits fast hit this in 3 of 20 runs under load. A mutation back toprocess.exit()still fails all three slow-pipe tests, so the 0.1.4: stop truncating stdout at 64 KiB through a pipe #5 regression stays covered.npm test: 12/12.🤖 Generated with Claude Code