Repository navigation
fix: a pasted job link shows the employer, not job-boards.greenhouse.io - #79
Merged
Merged
Conversation
Greenhouse's pages don't state the employer in their metadata, so the site's address was used instead. Greenhouse links now take the name from its job data, Lever links from the page title (which also leaves the employer out of the job title), and other application systems from the link. The bare address is only used when the site isn't an application system's, and a page naming the system as its site isn't believed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pasted job link could show
job-boards.greenhouse.ioorjobs.lever.coas the company. These pages don't state the employer in their metadata, so the code fell back to the site's address.What changed
The employer now comes from the first of these that gives one:
Results
Real links through the new code:
job-boards.greenhouse.io/catapultsports/…jobs.lever.co/mytos/…jobs.lever.co/bloomon/…Testing
Not covered