Repository navigation
V10.1.2/hotfix - #9
Merged
Merged
Conversation
Dependency discovery derived wildcard filters from package IDs, so a dependency could exclude project assemblies sharing its name prefix. Discovery now reads managed runtime assets from deps.json, including RID-specific ones, and emits exact filters. xUnit build assets that are copied without runtime entries are excluded explicitly.
The exclusion docs described wildcard dependency filters and a naming-convention limitation that no longer apply. They now describe deps.json discovery, exact assembly filters, and the xUnit build assets that are excluded explicitly.
The SDK can list a project runner DLL both as project output and in a reference entry, so dependency-derived exclusions dropped modules that should stay instrumented. Give project runtime assets precedence over duplicate reference entries and cover the case in the discovery test.
The fork inherited upstream PR coverlet-coverage#1946's prefix wildcards, which silently omitted project assemblies from reports in 10.0.1 through 10.1.1. Record the affected configurations, historical CI evidence, per-repository revalidation, and the unresolved Cuemon .NET Framework failure so consumers can judge their own reports.
Upstream syncs need verified commit targets that stay distinct from release numbering, so record the original upstream marker, the 10.1.1 comparison base, and the branch commits that implement this correction.
Readers of the top-level and integration docs need to see the advisory before trusting an existing coverage percentage, so link it from both entry points.
The 10.1.2 entry must describe restored project coverage and warn that corrected module selection changes totals, rather than describing the earlier exclusion-filter rewrite.
Cuemon's .NET Framework instrumentation dropped Cuemon.Core, Cuemon.Kernel, and Cuemon.Extensions.Core because the cached netstandard.dll facade was read without the owning resolver, so forwarded enum types resolved through Cecil's default resolver instead of Coverlet's framework fallbacks. Load the facade lazily per resolver, let the base cache own its disposal, and cover forwarded enums with a portable regression test.
The advisory described the Cuemon .NET Framework module loss as unresolved, but a second correction now restores those modules. Record the resolver cause, the before and after sequence-point evidence, the new regression test, and the Ubuntu remote results so readers can judge both defects and their remaining validation limits.
The provenance ledger only accounted for the dependency-filter correction, so add the second correction's upstream source pattern, its destination commit, and its validation results to keep the fork's provenance claims auditable.
Both entry-point warnings still called the Cuemon .NET Framework instrumentation failure unresolved, which now contradicts the shipped resolver correction. Point readers at the updated advisory status instead.
The 10.1.2 entry only mentioned the dependency-filter defect, so release readers would still expect the Cuemon module loss after upgrading. Describe the second fixed defect and its regression coverage.
[High impact] The PR appears safe to merge; no actionable new issues were found. SummaryThis patch restores project coverage through exact dependency exclusions and fixes forwarded enum resolution through the runtime
Reviews (3) · Last reviewed commit: "💬 document optional macOS validation" · Reviewed by Greptile |
The 10.x patch line now targets releases/v10 while master continues toward 11.0.0. Accept pull requests into either branch so maintenance changes receive the existing CI matrix without importing the next major release.
Keep the tested 10.1.1 package baseline on releases/v10 while master retains the planned 11.0.0 work. Explain forward-porting, fixed version tags, manual workflow selection, and the existing Production approval so a maintenance release follows the same guarded publication path.
Record releases/v10 at the exact 10.1.1 baseline, PR #9 retargeting, and the retained branch protections without rewriting master or the 11.0.0 work. The earlier manual CI run passed Windows and Ubuntu but could not acquire macOS runners, so package validation and publication remain unverified by that attempt.
Hosted macOS capacity repeatedly leaves the test matrix queued without acquiring a runner. Match the xUnit workflow policy with a manual run_mac_tests input, applying it to both tests and package validation. Windows and Ubuntu remain required, and every explicitly selected macOS job still gates publication.
Explain how to request the macOS test and package-validation matrices manually while Windows and Ubuntu remain mandatory. Record the hosted-runner queue limitation and distinguish an opted-out macOS run from validated compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes 10.1.2 a patch release that restores library coverage lost by automatically generated MTP exclusions and by a framework assembly-resolution failure. Dependencies now exclude only their own assemblies, and the runtime
netstandard.dllfacade is bound to the resolver that owns it, so project assemblies and .NET Framework modules are instrumented again. Package identity, public APIs, dependency versions, and thenetstandard2.0;net9.0;net10.0targets are unchanged.Dependency exclusion correction:
deps.jsonlibraries, including RID-specific assemblies, instead of from package IDs widened to a two-segment prefix.xunit.v3.mtp-v2are accepted as valid filters, and the xUnit build assets copied without runtime entries remain excluded by exact name.Framework resolver correction:
netstandard.dllfacade is loaded lazily per resolver with that resolver attached, so forwarded enum types resolve through Coverlet's framework fallbacks and configured search directories.Regression coverage:
deps.jsoninputs and assert that only dependency assemblies are excluded when names share a prefix, including differing package and assembly names and duplicate project or reference entries.Coverage advisory:
Upstream provenance:
Release notes: