[gimlichael]

This pull request brings in the reviewed upstream changes from coverlet-coverage/coverlet that fix exception-handler instrumentation and dynamic exclude filtering, updates the Microsoft Testing Platform dependency to 2.5.2, and records the synchronization in the fork's documentation.

Exception-handler instrumentation:

• Branch trampolines are skipped when an open-ended exception-handler region would pull them into a protected block, which could produce invalid IL in optimized loops; an inline or branch-local fallback keeps both branch paths recorded
• Instrumentation iterates over the original IL snapshot, so injected instructions no longer shift which instructions are processed
• Regression coverage with JIT-preparation checks covers the Issue 2058 loop and try/finally shapes

Dynamic exclude filters:

• Assemblies loaded in the controller process are excluded by exact name, which prevents a loaded helper such as MSS.Tools.xUnit from excluding a system under test such as MSS.Tools.Markdown
• Assembly filters may contain hyphens, and the related core and MTP tests and usage documentation are updated to match

Dependency updates:

• Microsoft Testing Platform is updated from 2.5.1 to 2.5.2 through the central package version

Documentation and release notes:

• The root changelog records the adopted fixes and the dependency update
• UPSTREAM.md records the reviewed upstream tip, the disposition of each incoming commit, and the validation performed for this operation

[greptile-apps]

Confidence Score: 4/5

[Medium impact] The changes affect coverage instrumentation and assembly selection in Coverlet runs.

The PR appears safe to merge, with a non-blocking gap in tests for executed coverage counts.

Findings

1.  Wrong coverage passes these tests ▶

Fix with agent prompt

### Issue 1
test/coverlet.core.coverage.tests/Coverage/CoverageTests.Issue2058.cs:75-77
The new tests prepare the methods for JIT compilation but never run them. `AssertMethodHasBothBranchPaths` only checks that some branches in the method have `Path` 0 and 1. It would still pass if the new local trampoline skipped a counter or one conditional lost a path.

Keep these checks for invalid IL, and add a bounded companion sample that runs both outcomes and checks each conditional's branch and line hit counts.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR updates exception-handler instrumentation, narrows exclusions for loaded assemblies, and updates Microsoft Testing Platform to 2.5.2.

• Coverage instrumentation keeps branch counters out of unsafe exception regions.
• Loaded helper assemblies get exact exclusions, while package names keep wildcard exclusions.
• The MTP integration and its related packages use version 2.5.2.
• The synchronization record tracks the reviewed upstream changes and their disposition.

No tests were run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Taken branch] --> B{End-of-method trampoline safe?}
  B -->|Yes| C[Append counter and jump]
  B -->|No| D{Target immediately before try start?}
  D -->|Yes, supported branch| E[Insert local counter and jump]
  D -->|Otherwise| F[Insert counter at target]
  C --> G[Continue at destination]
  E --> G
  F --> G

Loading

_{Reviews (1) · Last reviewed commit: "✅ verify windows release tests and updat..." · Reviewed by Greptile}

[greptile-apps]

Wrong coverage passes these tests

The new tests prepare the methods for JIT compilation but never run them. AssertMethodHasBothBranchPaths only checks that some branches in the method have Path 0 and 1. It would still pass if the new local trampoline skipped a counter or one conditional lost a path.

Keep these checks for invalid IL, and add a bounded companion sample that runs both outcomes and checks each conditional's branch and line hit counts.

Knowledge Base Used: Core coverage tests

Prompt To Fix With AI

This is a comment left during a code review.
Path: test/coverlet.core.coverage.tests/Coverage/CoverageTests.Issue2058.cs
Line: 75-77

Comment:
**Wrong coverage passes these tests**

The new tests prepare the methods for JIT compilation but never run them. `AssertMethodHasBothBranchPaths` only checks that some branches in the method have `Path` 0 and 1. It would still pass if the new local trampoline skipped a counter or one conditional lost a path.

Keep these checks for invalid IL, and add a bounded companion sample that runs both outcomes and checks each conditional's branch and line hit counts.

**Knowledge Base Used:** [Core coverage tests](https://app.greptile.com/-/switch-tenant?tenant=geekle&next=%2Fcustom-context%2Fknowledge-base%2Fcodebeltnet%2Fcoverlet%2F-%2Fdocs%2Fcore-coverage-tests.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.