Skip to content

docs: fix stale intent nodes after the SDK v2 release - #40

Merged
imbenrabi merged 2 commits into
mainfrom
claude/project-thread-3m7hfa
Nov 5, 2026
Merged

imbenrabi merged 2 commits into
mainfrom
claude/project-thread-3m7hfa

Conversation

@imbenrabi

Copy link
Copy Markdown
Contributor

Requested by Ben · project thread

Summary

Toolception half of todo item e8 ("make sure the intent layer is accurate in both repos"). I audited every AGENTS.md (root plus eight module nodes) against main at 0.9.0 (7ba8405). #35 and #38 had already brought the SDK v2, Zod 4, JSON Schema, readiness, Origin and multi-client claims in line with the code; I re-checked each of them against the source and found them correct. Four claims were still wrong:

  • src/meta/AGENTS.md (and a matching anti-pattern line): said a _meta catalog key causes a ToolRegistry name collision at registration. The ModuleResolver constructor throws on it (RESERVED_TOOLSET_KEYS), and validateToolsetName() refuses it again.
  • src/mode/AGENTS.md: now documents that reserved-key check and notes that moduleLoading.ts is an empty placeholder. Invariants renumbered, one cross-reference updated.
  • src/http/AGENTS.md: pointed at customEndpoints.ts and endpointRegistration.ts, which do not exist. The helpers are in http.utils.ts and http.types.ts.
  • src/session/AGENTS.md: the cache key is the plain clientId when the suffix is "default", and the hash covers values as well as keys.

Docs only. No source, test or changelog change, no release implied.

Base and merge order

Base: main. No stack.

Verification

Each changed claim was checked against ModuleResolver.ts, mode.types.ts, http.utils.ts, FastifyTransport.resolveSessionContext and SessionContextResolver.ts.



Generated by Claude Code

…he key)

- meta/mode: a catalog with a _meta key makes the ModuleResolver constructor throw (RESERVED_TOOLSET_KEYS); the nodes described a ToolRegistry collision at registration.
- http: custom endpoint helpers live in http.utils.ts and http.types.ts, not customEndpoints.ts / endpointRegistration.ts.
- session: the "default" suffix gives a plain clientId cache key, and the hash covers values as well as keys.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VmUXGTni8Lia5eQCbh2XUa
@imbenrabi imbenrabi self-assigned this Nov 5, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VmUXGTni8Lia5eQCbh2XUa

Copy link
Copy Markdown
Contributor Author

TS review: pipeline-ts-reviewer (feature-pipeline)

Verdict: COMMENT (3 LOW findings, no CRITICAL/HIGH). Reviewed git diff origin/main...HEAD (4 Markdown intent nodes; no TypeScript changed), so the review checked every changed claim against ModuleResolver.ts, mode.types.ts, http.utils.ts, FastifyTransport.resolveSessionContext and SessionContextResolver.ts. All claims hold; the renumbered invariants and the flow cross-reference are consistent.

# Sev Location Finding
1 LOW src/mode/AGENTS.md:14 Invariant 1 mixes the _meta rejection with an unrelated note that moduleLoading.ts is an empty placeholder.
2 LOW src/mode/AGENTS.md anti-patterns "Throwing on invalid toolset names" sits next to an invariant that the constructor throws on a reserved key; could confuse.
3 LOW src/session/AGENTS.md:17 The "default suffix" conditions omit malformed ?config=.
{"recommendation":"COMMENT","summary":"Every changed claim is accurate; only minor wording/scope nits remain.","findings":[{"severity":"LOW","file":"src/mode/AGENTS.md","line":14,"issue":"Invariant 1 bundles the moduleLoading.ts placeholder note with the _meta rejection."},{"severity":"LOW","file":"src/mode/AGENTS.md","line":null,"issue":"Anti-pattern about throwing on invalid names sits beside the constructor-throw invariant."},{"severity":"LOW","file":"src/session/AGENTS.md","line":17,"issue":"Default-suffix conditions omit malformed ?config=."}]}

Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Fix mapping for the TS review above

All three findings fixed in 1c24d8d.

  1. src/mode/AGENTS.md:14 (placeholder note in invariant 1): fixed. The moduleLoading.ts note moved out of the invariant into Key Components.
  2. Anti-pattern vs constructor throw: fixed. The anti-pattern now reads "Throwing on invalid toolset names at runtime (return a validation result instead; only a reserved key in the catalog throws, at construction)".
  3. src/session/AGENTS.md:17 (default-suffix conditions): fixed. It now says "no usable ?config=, meaning absent, malformed or empty after filtering".

Re-review follows.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

TS re-review: pipeline-ts-reviewer (feature-pipeline)

Verdict: APPROVE. Re-reviewed head 1c24d8d. All three LOW findings are fixed and match ModuleResolver, mode.types, SessionContextResolver and FastifyTransport; the mode node's invariant numbering and its (invariant #2) reference are correct. No new findings.

{"recommendation":"APPROVE","summary":"The three previously raised LOW wording issues are fixed and consistent with the source; numbering and references are correct.","findings":[]}

Generated by Claude Code

@imbenrabi
imbenrabi merged commit 7d163db into main Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants