Repository navigation
docs: fix stale intent nodes after the SDK v2 release - #40
Conversation
…he key) - meta/mode: a catalog with a _meta key makes the ModuleResolver constructor throw (RESERVED_TOOLSET_KEYS); the nodes described a ToolRegistry collision at registration. - http: custom endpoint helpers live in http.utils.ts and http.types.ts, not customEndpoints.ts / endpointRegistration.ts. - session: the "default" suffix gives a plain clientId cache key, and the hash covers values as well as keys. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VmUXGTni8Lia5eQCbh2XUa
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VmUXGTni8Lia5eQCbh2XUa
TS review:
|
| # | Sev | Location | Finding |
|---|---|---|---|
| 1 | LOW | src/mode/AGENTS.md:14 |
Invariant 1 mixes the _meta rejection with an unrelated note that moduleLoading.ts is an empty placeholder. |
| 2 | LOW | src/mode/AGENTS.md anti-patterns |
"Throwing on invalid toolset names" sits next to an invariant that the constructor throws on a reserved key; could confuse. |
| 3 | LOW | src/session/AGENTS.md:17 |
The "default suffix" conditions omit malformed ?config=. |
{"recommendation":"COMMENT","summary":"Every changed claim is accurate; only minor wording/scope nits remain.","findings":[{"severity":"LOW","file":"src/mode/AGENTS.md","line":14,"issue":"Invariant 1 bundles the moduleLoading.ts placeholder note with the _meta rejection."},{"severity":"LOW","file":"src/mode/AGENTS.md","line":null,"issue":"Anti-pattern about throwing on invalid names sits beside the constructor-throw invariant."},{"severity":"LOW","file":"src/session/AGENTS.md","line":17,"issue":"Default-suffix conditions omit malformed ?config=."}]}Generated by Claude Code
Fix mapping for the TS review aboveAll three findings fixed in 1c24d8d.
Re-review follows. Generated by Claude Code |
TS re-review:
|
Requested by Ben · project thread
Summary
Toolception half of todo item e8 ("make sure the intent layer is accurate in both repos"). I audited every
AGENTS.md(root plus eight module nodes) againstmainat 0.9.0 (7ba8405). #35 and #38 had already brought the SDK v2, Zod 4, JSON Schema, readiness, Origin and multi-client claims in line with the code; I re-checked each of them against the source and found them correct. Four claims were still wrong:src/meta/AGENTS.md(and a matching anti-pattern line): said a_metacatalog key causes a ToolRegistry name collision at registration. TheModuleResolverconstructor throws on it (RESERVED_TOOLSET_KEYS), andvalidateToolsetName()refuses it again.src/mode/AGENTS.md: now documents that reserved-key check and notes thatmoduleLoading.tsis an empty placeholder. Invariants renumbered, one cross-reference updated.src/http/AGENTS.md: pointed atcustomEndpoints.tsandendpointRegistration.ts, which do not exist. The helpers are inhttp.utils.tsandhttp.types.ts.src/session/AGENTS.md: the cache key is the plainclientIdwhen the suffix is"default", and the hash covers values as well as keys.Docs only. No source, test or changelog change, no release implied.
Base and merge order
Base:
main. No stack.Verification
Each changed claim was checked against
ModuleResolver.ts,mode.types.ts,http.utils.ts,FastifyTransport.resolveSessionContextandSessionContextResolver.ts.Generated by Claude Code