Skip to content

chore(deps): update vite-plugin-dts to ^5.1.2 (stacked on #35) - #36

Merged
imbenrabi merged 3 commits into
claude/project-thread-1w8fkyfrom
claude/project-thread-1w8fky-t1-dts
Nov 5, 2026
Merged

imbenrabi merged 3 commits into
claude/project-thread-1w8fkyfrom
claude/project-thread-1w8fky-t1-dts

Conversation

@imbenrabi

Copy link
Copy Markdown
Contributor

Requested by Ben · project thread

Stack and merge order

Base: #35 (claude/project-thread-1w8fky, SDK v2 + Zod 4). This PR is T1 and targets that branch. Merge order: #35 first, then this PR (GitHub retargets it to main when #35 merges), independent of T2 and T3 (disjoint files). The 0.9.0 release PR comes after all of them. Nothing is tagged or published.

What changed

  • vite-plugin-dts ^4.5.4 → ^5.1.2 (dev dependency). This removes the sprintf-js / minimatch advisories that came through vite-plugin-dts 4 (@microsoft/api-extractor, @vue/language-core).
  • overrides: @microsoft/api-extractor → minimatch ^11.0.1. api-extractor 7.60.1 is the latest release and still pins minimatch 10.2.3 (GHSA-g3hv-75wg-m249, moderate, no upstream fix yet), so only that dev-only dependency is moved. Drop the override once api-extractor ships a fixed minimatch.

Verification (Node 26.13.0)


Generated by Claude Code

Clears the sprintf-js / minimatch advisories reported through vite-plugin-dts 4
(@microsoft/api-extractor, @vue/language-core). api-extractor 7.60.1 is the
latest release and still pins minimatch 10.2.3 (GHSA-g3hv-75wg-m249), so an
override moves only that dev-only dependency to minimatch ^11.0.1. The built
dist (declarations and bundle) is identical to the previous build.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VmUXGSYMuTcM7fquxzRook
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VmUXGSYMuTcM7fquxzRook

Copy link
Copy Markdown
Contributor Author

TS review: pipeline-ts-reviewer (feature-pipeline)

Verdict: APPROVE (round 1). No CRITICAL/HIGH findings. The reviewer confirmed the override is scoped to @microsoft/api-extractor only, the lockfile has a single minimatch 11.0.4 consumed only by api-extractor, engines are compatible (minimatch 11 20 || >=22, repo >=25.3.0), it ships nowhere (overrides are ignored in published packages), npm audit reports 0, and nothing in the diff goes beyond the stated intent.

# Sev Location Finding Resolution
1 LOW CHANGELOG.md [Unreleased] > Fixed The line "Only the dev-only minimatch chain through vite-plugin-dts 4 remains…" is stale once this PR removes that chain. Fixed in 51f8949: it now says vite-plugin-dts 5 and a dev-only minimatch override clear the last dev-only audit findings.
2 LOW package.json overrides The override targets api-extractor, which is only an optional peer kept in the lockfile (the build does not run it, so the empty dist diff does not exercise it). Record the exit condition. Recorded here, since package.json has no comments: the override can be dropped once @microsoft/api-extractor releases past 7.60.1 with minimatch >=10.2.4, or once the optional peer leaves the tree. If a fresh install stops installing that peer, the override just becomes inert.
{
  "recommendation": "APPROVE",
  "summary": "Minimal, correctly scoped dev-only dependency bump and nested minimatch override; engines are compatible, the lockfile has a single minimatch 11.0.4 consumed only by api-extractor, and nothing beyond stated intent is touched.",
  "findings": [
    { "severity": "LOW", "file": "CHANGELOG.md", "line": 21, "issue": "The [Unreleased] Fixed entry still says the dev-only minimatch chain through vite-plugin-dts 4 remains." },
    { "severity": "LOW", "file": "package.json", "line": 83, "issue": "Note the exit condition for removing the api-extractor minimatch override." }
  ]
}

Generated by Claude Code

@imbenrabi
imbenrabi merged commit b7ef309 into claude/project-thread-1w8fky Nov 5, 2026
imbenrabi added a commit that referenced this pull request Nov 5, 2026
…lease-0-9-0

chore(release): 0.9.0 (also lands #36, #37, #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants