Repository navigation
chore(deps): update vite-plugin-dts to ^5.1.2 (stacked on #35) - #36
Merged
imbenrabi merged 3 commits intoNov 5, 2026
Merged
Conversation
Clears the sprintf-js / minimatch advisories reported through vite-plugin-dts 4 (@microsoft/api-extractor, @vue/language-core). api-extractor 7.60.1 is the latest release and still pins minimatch 10.2.3 (GHSA-g3hv-75wg-m249), so an override moves only that dev-only dependency to minimatch ^11.0.1. The built dist (declarations and bundle) is identical to the previous build. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VmUXGSYMuTcM7fquxzRook
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VmUXGSYMuTcM7fquxzRook
Contributor
Author
TS review:
|
| # | Sev | Location | Finding | Resolution |
|---|---|---|---|---|
| 1 | LOW | CHANGELOG.md [Unreleased] > Fixed |
The line "Only the dev-only minimatch chain through vite-plugin-dts 4 remains…" is stale once this PR removes that chain. |
Fixed in 51f8949: it now says vite-plugin-dts 5 and a dev-only minimatch override clear the last dev-only audit findings. |
| 2 | LOW | package.json overrides |
The override targets api-extractor, which is only an optional peer kept in the lockfile (the build does not run it, so the empty dist diff does not exercise it). Record the exit condition. |
Recorded here, since package.json has no comments: the override can be dropped once @microsoft/api-extractor releases past 7.60.1 with minimatch >=10.2.4, or once the optional peer leaves the tree. If a fresh install stops installing that peer, the override just becomes inert. |
{
"recommendation": "APPROVE",
"summary": "Minimal, correctly scoped dev-only dependency bump and nested minimatch override; engines are compatible, the lockfile has a single minimatch 11.0.4 consumed only by api-extractor, and nothing beyond stated intent is touched.",
"findings": [
{ "severity": "LOW", "file": "CHANGELOG.md", "line": 21, "issue": "The [Unreleased] Fixed entry still says the dev-only minimatch chain through vite-plugin-dts 4 remains." },
{ "severity": "LOW", "file": "package.json", "line": 83, "issue": "Note the exit condition for removing the api-extractor minimatch override." }
]
}Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Stack and merge order
Base: #35 (
claude/project-thread-1w8fky, SDK v2 + Zod 4). This PR is T1 and targets that branch. Merge order: #35 first, then this PR (GitHub retargets it tomainwhen #35 merges), independent of T2 and T3 (disjoint files). The 0.9.0 release PR comes after all of them. Nothing is tagged or published.What changed
vite-plugin-dts^4.5.4→^5.1.2(dev dependency). This removes thesprintf-js/minimatchadvisories that came throughvite-plugin-dts4 (@microsoft/api-extractor,@vue/language-core).overrides:@microsoft/api-extractor→minimatch ^11.0.1.api-extractor7.60.1 is the latest release and still pinsminimatch10.2.3 (GHSA-g3hv-75wg-m249, moderate, no upstream fix yet), so only that dev-only dependency is moved. Drop the override onceapi-extractorships a fixedminimatch.Verification (Node 26.13.0)
npm audit: 0 vulnerabilities (was 4 moderate on feat!: move to MCP SDK v2 and Zod 4 (base) #35).npm audit --audit-level=criticalpasses.diff -r dist <dist built on #35>is empty, so the published declarations and bundle are identical.npm run typecheck✔,npm run test:run✔ (412 tests at branch point; 411 after feat!: move to MCP SDK v2 and Zod 4 (base) #35's review fixes, run on the merged branch).Generated by Claude Code