Skip to content

final review - #223

Merged
CMGS merged 2 commits into
mainfrom
review/post-222
Sep 22, 2026
Merged

CMGS merged 2 commits into
mainfrom
review/post-222

Conversation

@CMGS

@CMGS CMGS commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Whole-repo review round on main f36a3d9, after #220, #221 and #222 landed.

Every file whose blob changed since the last closed round was read in full against the style, judge and LOC lenses (22 style, 17 judge); the hygiene ledger is at 0 due for both. Nothing in executable code needed to change.

What this PR changes

Two review: commits, comments and layout only:

  • Comment budgetheldConn's doc still said "preview connection" after sandboxd: a guest-port relay and lease renewal #221 made dialPort serve port relays too (the comment dates from pool: keep the idle sweep off a sandbox with a live connection #176); keepAlive's doc restated the const block's WHY; three restating docs on e2e constants and a helper; three wrapped two-line docs folded to one line; a test helper in silkd/tests/ carried a doc block. Net −13 comment lines, no executable line touched.
  • silkd layoutsysutil's private make_controlling_tty sat between two public fns; proc's State enum is vocabulary and now clusters with Chunk ahead of Table. Pure moves.

What was verified and kept

  • Renew's archive guard and CAS rollback (Codex P2-2/P2-3) carry three real-trigger tests; a zero-value claimSnapshot reaching recommit is a no-op (commit skips seq <= written).
  • keepAlive on the hijacked conn is kept: the API server terminates no TLS, so the *net.TCPConn assertion always holds; without it a client that dies without a FIN leaves a held sandbox until lease expiry.
  • forward.rs's independent half-close, the Ring tag coalescing, find's byte budget and the Python whole-dial deadline all re-read clean; no unjustified clone in the touched Rust.
  • Claim path: untouched by silkd: loc-justify round, Rust half #219os-image: e2b-rt, the flavor an unmodified e2b SDK can drive #222; the new /ports and /renew surfaces are per-connection and per-call.

LOC

Cut-list: empty. The two sub-threshold folds (decodeBody/decodeOptionalBody −5; HTTPOverPort/relayGet −10 in e2e scaffolding) are recorded as skipped. Shippable Go prod moved +106 across the five PRs; the rest of the range's prod growth (+960) is e2e scaffolding.

Gates

  • Go: make go-lint 10× 0 issues.; asl -forwarder=false clean on both GOOS in all five modules; go test -race green; GOOS=windows go vet on sdk/go green.
  • Rust: fmt, clippy -D warnings, tests green on macOS and in a linux/arm64 container (silkd 128 passed, boot/init 17).
  • Python: ruff format/check, pytest 215, mypy strict on the package, sdk/openai 10 and sdk/langchain 14 on Python 3.12.

heldConn's comment still named preview after dialPort went generic; keepAlive restated the const block; three restating comments on e2e constants and a helper; three wrapped comments folded to one line; a test helper carried a doc block.
sysutil's private make_controlling_tty sat between two public fns; proc's State enum is vocabulary and now clusters with Chunk ahead of Table.
@CMGS CMGS changed the title review: whole-repo round on main f36a3d9 final review Sep 22, 2026
@CMGS
CMGS merged commit 81ece2f into main Sep 22, 2026
2 checks passed
@CMGS
CMGS deleted the review/post-222 branch September 22, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant