cut: apply the review round's report-only cut-list - #125
Merged
Merged
Conversation
CMGS
force-pushed
the
fix/upstream-contract-followups
branch
from
September 23, 2026 12:04
ed42632 to
600c6c6
Compare
… share helpers Four inline batch poll loops in the e2e suite use wait_batch; the BatchItem and BatchItemResult test literals in the handler and store suites use item() and result(); compat.rs, live_path.rs and e2e.rs read one body_json from the shared test module; bench.rs measures its three serial runs through one timing loop and one percentile function.
…sage fields Two mock reply builders copied a &str they only read; response_v2 and common_usage wrote null into every cached entry where the sibling Option fields are skipped.
CMGS
force-pushed
the
cut/test-dedup-and-small-cuts
branch
from
September 23, 2026 12:54
bc4230f to
8e123d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #124. The report-only cut-list from #123's review round, applied and nothing else.
e2e.rs→wait_batch;BatchItem(13) andBatchItemResult(5) test literals in the handler and store suites →item()/result();body_jsonfromcompat.rs,live_path.rsande2e.rs→ one copy intests/common; the three serial timing loops and percentile closures inbench.rs→serial()andpct()to_owned()on a&strthe mock reply only reads;response_v2andcommon_usagegainskip_serializing_if, so a cachedGatewayResponseno longer writes twonulls (a missing key reads back asNone, so entries written before this change still load)No behaviour changes: the tests assert what they asserted, the bench prints what it printed, the mock answers what it answered.
Verification
git archive | tar -m), passcargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspace: 679 passed, 0 failed each (the count is unchanged, as a cut should leave it).rust:1linux/arm64 container with rustc 1.98.0: fmt ✓, clippy ✓, 679 passed, 0 failed, 4 ignored.nulls in a cache entry; neither is on a served request's path.Size
Production code +1 net (the two serde attribute lines less the mock's dropped copy); tests −145 net. Comment lines in
*.rs: 0 added, 0 removed. Whole-repo non-blank production Rust 26146 → 26147, comment density 8.75% unchanged. The hot path is untouched: the mock transport serves only tests and the in-process bench, and a cache write serializes two fewer bytes-worth ofnull.