review: settle the asl forwarder advisories - #41
Merged
Merged
Conversation
asl's forwarder advisory flagged newCRLogger: one call site in main and one statement, so main builds the sink logger directly. The other two advisories, hasPhaseDeadline and vmClonedAndRunning, carry a WHY comment the call site cannot and stay; both are recorded as kept in the hygiene ledger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
aslnow carries aforwarderadvisory: an unexported one-statement func with exactly one call site. Three fired here; this settles them.What
newCRLoggerinlined:mainbuildslogr.New(&crSink{ctx: ctx})directly (net -4 lines).hasPhaseDeadlineandvmClonedAndRunningstay: each carries a WHY the call site cannot (the deadline-reset rule, the clone-before-Running race). Both are recorded as kept in the hygiene ledger so the advisory does not resurface.No behaviour change; no comment added.
Evidence
GOWORK=off make fmt-checkrc=0;GOWORK=off make lintrc=0 with two0 issueslines (linux + darwin);asl ./...on both GOOS reports only the two kept advisories;GOWORK=off go test -race -count=1 ./...rc=0, no FAIL lines.