review: cmp.Or for zero-value fallbacks - #40
Merged
Merged
Conversation
The asl cmpor analyzer rewrites the if/return and if/assign zero-value fallbacks into cmp.Or where the fallback is call-free and the two label-value comments go (labelenum: docs/metrics own the values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First gate run of the new asl analyzers:
cmporrewritesif x != zero { return x }; return yandif x == zero { x = y }intocmp.Or(x, y)where the fallback is call-free (cmp.Or evaluates every argument). and the two label-value comments go (labelenum: docs/metrics own the values)What
0 cmp.Or rewrites, applied by
asl -fixandgoimports; no behaviour change.Evidence
make fmt-checkclean;make lint0 issues on linux and darwin;aslclean on both GOOS;go test -race -count=1 ./...with no FAIL lines (log kept locally).