Repository navigation
Gate unchanged RM3 PTO Extension inputs with physical Python runs - #664
Merged
Merged
Conversation
cmccomb
marked this pull request as ready for review
October 24, 2026 17:10
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local evidence
Both physical 301-sample runs pass the inherited limits. Largest active gaps are float 85.849 mm heave/stroke and 202.600 mm/s speed against 90 mm and 210 mm/s, and spar 14.877 mm and 6.522 mm/s against 18 mm and 8 mm/s. The float speed margin is 7.400 mm/s (3.52% of its limit). The source-ode4 control matches the source active heave within 7e-12 m, while the qualifying physical trajectory remains distinct.
python -m pytest -q tests/test_rm3_pto_extension_published_physical.py: 3 passed locally. The optional fresh-source checks also passed against the downloaded original MATLAB artifact;actionlintpassed for the new workflow.Interpretation
These are formal passes under inherited thresholds, not a claim that the coarse published MATLAB trajectories are source-converged or pointwise reproduced. The original limits preceded this source-step investigation but were not chosen prospectively blind to all earlier errors. A source-only FixedStep refinement still removes over 99% of the float and over 99.99% of the spar squared gap to a refined trace. The corrected fine-step baselines remain separate. This PR leaves all case status, badge counts, and issue states unchanged pending review and exact-head Linux CI.
Related: #624, #618.