Repository navigation
Investigate heave-only added-mass loop correction for ellipsoid ode45 - #658
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Investigate issue #599 with a derived heave-only mass shift on disposable copies of the pinned
Nonlinear_Hydro/ode45inputs. The WEC-Sim core, Applications repositories, and the existing published-input 0.05 s numerical solver-envelope gate remain unchanged. This PR does not claim published-input parity; issue #599 remains open.The core shifts
D = adjMassFactor × trace(A_xyz)into rigid translational mass and sends the residual added-mass acceleration force through a 100 ns Transport Delay. Each copied input derivesadjMassFactor = A_zz / trace(A_xyz)from the pinned source HDF5 and selected wave mode. For these single active heave-coordinate models, the delayed heave coefficient becomes zero while effective heave mass remainsm + A_zz. The shift also changes inactive surge and sway masses, so this is not a general multidimensional core correction.Measured evidence
The full 150 s R2025b source run at head
963f97442da8258578c1fde94c9f6d3bcb78050ecompleted Regular and RegularCIC at the published 0.05 s clock and a refined 0.005 s solver/nonlinear-force/CIC clock. Both retain a 0.05 s output grid. The actual applied delayed heave force stays below6e-22 N; inactive accelerations stay below1.3e-21.The corrected 0.005 s comparison passes the established pointwise physical limits for heave, speed, PTO force, and absorbed power. The corrected 0.05 s comparison fails those 3/3.5 mm physical heave limits and even the unchanged-input test's broader 22/23 mm numerical solver envelope. Its source self-change also exceeds the established 3/3.75 mm heave stability screens. Removing active heave added-mass feedback alone does not close the published-clock gap.
Reproducibility
Measured results and provenance include the exact source commits, run, generated HDF5, and compact traces. Ordinary Python CI independently advances motion and PTO against these traces. It has a positive refined physical gate and two strict expected failures for corrected published-clock physical closure and source step stability; an unexpected pass fails. The source workflow regenerates and repacks both cases and compares them with the archived traces. No status or badge changes are included.