Repository navigation
Keep original OWC physical motion failure explicit - #656
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OWC/OrificeModelphysical-motion comparison explicit as a strict expected failure. It uses the existing independently advanced 130 s Python trajectory; the module-scoped fixture prevents a second expensive solve.PublishedPhysicalMotionGapexception is the only accepted expected-failure outcome, so unrelated setup or source errors still fail CI and an eventual pass becomes a strict XPASS.The unchanged published source and physical Python share all 26,001 output times, wave samples, 500 PM phases, the pinned HDF5, and orifice parameters. Measured Python/original gaps are 0.1735 m surge, 1.9420 m heave, 0.01071 rad pitch, 0.2798 m flexible displacement, and 99.73% integrated PTO work. This remains a diagnostic of the published model's omitted piston reaction; it does not promote the original input or change any badge or case classification.
Verification
python -m pytest -q -rx tests/test_owc_orifice_corrected_full.py tests/test_owc_orifice_corrected_piston.py tests/test_owc_orifice_130s_portable.py— 3 passed, 1 expected failure.Related to #622. This PR leaves that issue closed and does not change #624.