osmorphing minion pools: use the correct volumes - #508
Open
petrutlucian94 wants to merge 1 commit into
Open
Conversation
petrutlucian94
marked this pull request as draft
August 26, 2026 13:44
petrutlucian94
force-pushed
the
minion_volumes
branch
from
August 26, 2026 13:52
425bcb0 to
faeb0cc
Compare
petrutlucian94
changed the title
petrutlucian94
marked this pull request as ready for review
August 26, 2026 13:53
petrutlucian94
force-pushed
the
minion_volumes
branch
from
August 26, 2026 15:09
faeb0cc to
17da02e
Compare
We're attaching the original `volumes_info` to osmorphing minions instead of the volumes returned through `instance_deployment_info` by the `deploy_replica_target_resources` provider method. This breaks disk clones since we're writing to the original transfer disk instead of the disk clone. Furthermore, we're modifying the list of volumes from `instance_deployment_info` after attaching the minion volumes. https://github.com/cloudbase/coriolis/blob/1c7bf332545826b0c79a5c1efa14b8ce905f0646/coriolis/tasks/minion_pool_tasks.py#L683-L687 Because of that, we're deleting the original volume instead of the clone if osmorphing fails. The fix is simple: get the osmorphing minion pools to use the volumes from `instance_deployment_info` instead of the original ones, if available.
petrutlucian94
force-pushed
the
minion_volumes
branch
from
August 27, 2026 11:10
17da02e to
92ff02a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're attaching the original
volumes_infoto osmorphing minions instead of the volumes returned throughinstance_deployment_infoby thedeploy_replica_target_resourcesprovider method.This breaks disk clones since we're writing to the original transfer disk instead of the disk clone. Furthermore, we're modifying the list of volumes from
instance_deployment_infoafter attaching the minion volumes.coriolis/coriolis/tasks/minion_pool_tasks.py
Lines 683 to 687 in 1c7bf33
Because of that, we're deleting the original volume instead of the clone if osmorphing fails.
The fix is simple: get the osmorphing minion pools to use the volumes from
instance_deployment_infoinstead of the original ones.