Repository navigation
Add /tempyr-spar and the interview kill-pass critic (S3a) - #58
Merged
Merged
Conversation
|
Warning Review limit reached
This review includes 12 billable files and costs up to $3.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 43 minutes for your next included review. View limit details
Comment |
cleak
force-pushed
the
feat/interview-eval-harness
branch
from
October 11, 2026 22:05
277e6e3 to
f4785e9
Compare
cleak
force-pushed
the
feat/interview-spar
branch
from
October 11, 2026 22:05
b143b0f to
87506cd
Compare
cleak
force-pushed
the
feat/interview-eval-harness
branch
from
October 13, 2026 04:11
f4785e9 to
644084a
Compare
Stage S3a of the interview-challenge proposal: an independent critic
that challenges graph nodes in a fresh context, on demand or once per
interview.
- tempyr-critic subagent: one critic, lens passed in (kill-pass,
pre-mortem, assumptions, outside-view; mandate-focus variant). Works
only from a node packet plus settled items, never the conversation;
every objection quotes >=15 chars verbatim from its target node; "no
objection" is valid.
- /tempyr-spar <node>: builds the packet with graph_traverse
{include_body}, collects prior rebuttals via journal_search tag and
reference filters, validates quotes, shows the top 3, and applies
accept / rebut / dismiss / change in one line. Every disposition is
journaled with references + tags so rebutted objections never return.
- Interview skill: a background kill-pass at the Product -> Technical
boundary with an outside-view packet (no solution nodes); its result
becomes the next push.
- Extractor returns a weakest_claim and marks weak answers `needs:`.
- The spar skill and critic agent are managed files implied by the
existing Skill / Agent selections (the manifest keeps recording only
the user-facing artifacts); Codex gets mirrored skills.
- Eval harness runs the kill-pass for arms that have one and scores
whether the interviewer surfaced it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…gaps - Agent definitions use the `tools:` frontmatter key (Claude Code ignores `allowed-tools:` there), so the critic really is limited to graph_get_node; same fix for the extractor. - The critic is installed with the Skill artifact, since the interview and spar skills are what launch it. - Codex gets the critic's instructions at .agents/skills/tempyr-spar/ critic.md, and both skills fall back to an in-session critique pass that sees only the packet when the subagent isn't available. - Spar/kill-pass accepts set valid statuses (risk: identified, open_question: open); kill-pass settled items include dismissals; an interview that reaches Review without starting the kill-pass runs it there. The push-priority list regains the kill-pass result. - Eval harness: the judge only grades kill-passes whose result reached the interviewer, and the eval critic ignores recorded answers other than the premise reply, matching the real kill-pass's view. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cleak
force-pushed
the
feat/interview-spar
branch
from
October 13, 2026 04:14
87506cd to
0827503
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is S3a of
docs/interview-challenge-research.md. It's stacked on #57 (eval harness), which is stacked on #55 (skill) and #54 (Rust). It relies on #54'sgraph_traverse {include_body},interview_show {full}, andjournal_searchtag/reference filters.Research and five rounds of critic review pointed the same way. Critics work best when they are independent, run in a fresh context, define their target narrowly, and get filtered deterministically. A multi-agent debate panel would not have done as well. Critics also belong in an on-demand command that can challenge any node, including ones no interview ever touched. They should not be wired into every turn.
tempyr-critic(subagent)/tempyr-spar <node> [hops N] [lens …|panel]graph_traverse. Outside-view and kill-pass packets drop solution nodes.needs:line, or a generated block.1a 2r launchd handles it 3d.referencesandtags: ["disposition:…"], so a rebutted objection never comes back.Interview kill-pass
Also
weakest_claim(a push candidate written from a fresh context) and marks weak answers withneeds:.SparSkillandCriticAgent. They're implied by the existingSkillandAgentselections, so existing projects get them on update. The manifest still records only the user-facing artifacts, so older binaries can read it..agents/skills/.Test plan
cargo test -p tempyr-clipasses. New test:SkillandAgentimply the spar skill and critic, and the manifest records onlyHooks,Skill, andAgent. Updated two tests that assumed three managed files.cargo clippy -p tempyr-cli --all-targetsandcargo fmt --check.workflow.jswith mocks. The kill-pass runs once per kill-pass arm after Technical, is delivered on the next turn, and the baseline reports none.setup.shcopies the critic into the sandbox./tempyr-sparon a real graph, and kill-pass numbers from a full/tempyr-evalrun.🤖 Generated with Claude Code