Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Public CI / proto (pull_request).
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, well-scoped to integration behavior and feature-gated ownership semantics, and include a direct test assertion for the new configuration.
Pull request overview
This PR reduces CI runner memory pressure during integration tests by disabling Reth’s precompile caching for in-process multi-node test runs, while also adjusting ArcContext ownership handling so Clippy passes under both default and byzantine feature builds.
Changes:
- Disable Reth precompile caching in the integration node
NodeConfigto avoid per-node cache allocations. - Add a unit test asserting the integration node execution config disables the precompile cache.
- Make
ArcContextconsumption explicit by cloning only inbyzantinebuilds (where it is non-Copy), and moving/copying in non-byzantinebuilds.
File summaries
| File | Description |
|---|---|
| crates/test/integration/src/runner.rs | Disables precompile_cache_disabled for integration nodes and adds a small assertion test to lock in the behavior. |
| crates/malachite-app/src/node.rs | Adjusts ArcContext ownership to satisfy feature-dependent Copy/Clone semantics and keep Clippy clean across configs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ZhiyuCircle
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #298
Summary
Disable Reth precompile caching for in-process integration nodes. These scenarios
do not exercise precompile caching, and the pinned Reth version reserves a large
cache for every precompile on every node. Avoiding those allocations preserves
the seven-node sync coverage while reducing runner memory pressure.
Also make
ArcContextownership explicit across default and Byzantine featurebuilds so Clippy succeeds in both configurations.
Changes
ArcContextaccording to its feature-dependent ownership semantics.Testing
cargo fmt --all -- --checkcargo nextest run --locked -p arc-test-integration --test-threads 1cargo nextest run --locked -p arc-test-integration validators_and_full_nodes_reach_height_3 --test-threads 1cargo nextest run --locked -p arc-node-consensus(462 tests)cargo clippy --locked -p arc-test-integration --all-targets --all-features -- -D warningscargo clippy --locked -p arc-node-consensus --all-targets --features byzantine -- -D warningsAdditional Context
Reth fixed the oversized precompile-cache reservation upstream in
paradigmxyz/reth#25013. This change avoids that
production-sized cache in integration scenarios while arc-node remains pinned
to Reth v2.2.0.
No breaking changes.