Skip to content

fix(deps): patch rand to 0.9.3 - #464

Merged
tobyhede merged 1 commit into
mainfrom
fix-cip-3961-rand-patch
Sep 7, 2026
Merged

fix(deps): patch rand to 0.9.3#464
tobyhede merged 1 commit into
mainfrom
fix-cip-3961-rand-patch

Conversation

@tobyhede

@tobyhede tobyhede commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Dependency patch for rand to 0.9.3.

This is an automated security patch update.

@tobyhede
tobyhede requested a review from freshtonic September 6, 2026 23:39

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rand remediation is correct and CI is green: the vulnerable 0.9.2 lock entry is replaced by the patched 0.9.3 release, with no affected rand version left in the lockfile.\n\nBlocking: commit fcc941f has no Signed-off-by: trailer. CONTRIBUTING.md requires every commit to be signed off under the DCO. Please amend the commit with --signoff and force-push.\n\nNon-blocking: the tempfile entry also moves from getrandom 0.3.2 to 0.4.2. That appears to be harmless unrelated lockfile resolution churn and could be minimized, but it is not grounds for rejection.

Bumps rand 0.9.2 -> 0.9.3 for GHSA-cq8v-f236-94qc.

Claude-Session: https://claude.ai/code/session_01N68ztp2ddYAfuo4jUDD88h
Signed-off-by: Toby Hede <toby@cipherstash.com>
@tobyhede
tobyhede force-pushed the fix-cip-3961-rand-patch branch from fcc941f to 9a0bf22 Compare September 7, 2026 00:20

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete: the prior DCO blocker is fixed. Commit 9a0bf22e now has the required Signed-off-by trailer and retains a valid Conventional Commit subject.

The CIP-3961 remediation remains correct: the vulnerable rand 0.9.2 lock entry is replaced by patched 0.9.3, all dependency edges resolve to it, and the other locked rand versions (0.8.6 and 0.10.2) are also patched for GHSA-cq8v-f236-94qc. The lockfile resolves successfully with --locked --offline.

The unrelated tempfile/getrandom resolution change remains harmless and non-blocking. Approved.

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on re-review of 9a0bf22. The required DCO sign-off is present, and the lockfile exactly reproduces the rand 0.9.2 to 0.9.3 remediation for GHSA-cq8v-f236-94qc. The remaining rand entries (0.8.6, 0.9.3, and 0.10.2) are outside the advisory ranges. The tempfile edge selecting the already-present getrandom 0.4.2 is valid resolver output and non-blocking.

Non-blocking documentation note: AGENTS.md asks notable changes to update CHANGELOG.md Unreleased, but this security patch has no changelog entry. That documentation omission does not block this approval.

Local all-target workspace checks pass; GitHub CI is still in progress.

@tobyhede
tobyhede merged commit a11c26b into main Sep 7, 2026
6 checks passed
@tobyhede
tobyhede deleted the fix-cip-3961-rand-patch branch September 7, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants