Repository navigation
Config class - #65
Open
chazlarson wants to merge 14 commits into
Open
Config class#65chazlarson wants to merge 14 commits into
chazlarson wants to merge 14 commits into
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Merge main into config-class, keep asset-type subfolders and substring collection deletes on the yaml config, and fix the remaining config wiring and ruff failures. Co-authored-by: chaz <chaz@chazlarson.com>
tmdb-people, get_TMDB_Original_Language, and kometa-helpers now read the shared config, and the unused dotenv upgrade helper is gone. Co-authored-by: chaz <chaz@chazlarson.com>
It lists and launches scripts by name for a container command, and opens the existing menu on a terminal. Co-authored-by: chaz <chaz@chazlarson.com>
The menu and container entry point no longer launch it, and a Docker build of this repo ignores that directory. Co-authored-by: chaz <chaz@chazlarson.com>
MEDIA_SCRIPTS_CONFIG_DIR points at /config, which holds config.yaml and the plex, kometa, and tmdb folders scripts write into. Co-authored-by: chaz <chaz@chazlarson.com>
The notes record the Docker mount, what is already decided, and the build that still needs to run. Co-authored-by: chaz <chaz@chazlarson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from a
.envfile to aconfig.ymlChanges from a
.envfile to aconfig.ymlSummary
Moves script configuration from
.envfiles to a sharedconfig.yaml(copied fromconfig.template.yaml) and aConfighelper used by the Plex, Kometa, and TMDB scripts.This update also:
main, including asset-type subfolders fororiginals-to-assets.pyand substring collection deletes, both read fromconfig.yamlreset_posters.target_labelsinreset-posters-tmdb.py,kometa.config_dirinoriginals-to-assets.py)TMDB/tmdb-people.py,TMDB/get_TMDB_Original_Language.py, andKometa/kometa-helpers.pyontoconfig.yaml, and removes the unused dotenv upgrade helperorchestrator.pyas the single entry point:list, a script name, ormenu. The Plex Image Picker is not includedDockerfilewhose/configmount holdsconfig.yamland theplex/,kometa/, andtmdb/folders scripts write intograb-all-status.py(sysandtextwrapwere used without imports) and the TMDB logo downloader progress loopConfigexample with placeholders, and stops usingevalfor boolean settings.cursor/orchestrator-handoff.mdso a follow-up agent can build the image without rediscovering the decisions. That file is session notes and can be removed before mergeGitGuardian flagged sample keys in an earlier commit on this branch (
Plex/config.py). Those values are gone from the current files. The incident can be resolved in the GitGuardian dashboard. If those keys were real, rotate them.Test plan
ruff check .python -m compileallconfig.template.yamlparsestmdb_people,original_language, and Plex URL/token fromconfig.yamlorchestrator.py listomits the image picker, andpickerexits with an errorMEDIA_SCRIPTS_CONFIG_DIRset, the orchestrator seedsconfig.yamland runs scripts fromplex/,kometa/, andtmdb/docker buildand a run against a live Plex server