Skip to content

[entities] Tighten the entity deletion rights - #1330

Merged
frankrousseau merged 2 commits into
cgwire:mainfrom
frankrousseau:main
Oct 29, 2026
Merged

frankrousseau merged 2 commits into
cgwire:mainfrom
frankrousseau:main

Conversation

@frankrousseau

Copy link
Copy Markdown
Contributor

Problem

  • DELETE /data/entities/ let the creator of an entity delete it without a team check, so a person removed from the project could still delete it
  • With force=true, a creator who is not a manager could delete the tasks, shots and files others made below their entity

Solution

  • Use check_entity_delete_access on the CRUD entity route, as the asset, shot and sequence routes do
  • Require manager access on the project for a forced entity deletion

frankrousseau and others added 2 commits October 29, 2026 10:15
With force=true, deleting an entity also removes the tasks, shots, scenes
and files others made below it. The creator of the entity could do it
from the team alone. check_entity_delete_access now asks for manager
access on the project when force is set, for assets, concepts, edits,
shots, episodes, sequences and the entity batch deletion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e team

DELETE /data/entities/<id> let the creator of an entity delete it without
any membership check, so a person removed from the project team could
still delete what they had created. The CRUD route now uses
check_entity_delete_access, like the asset, shot and sequence routes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frankrousseau
frankrousseau merged commit d916195 into cgwire:main Oct 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant