Repository navigation
[otio] Import the EDL of a production at an NTSC frame rate - #1329
Merged
Merged
Conversation
The EDL import passed the production fps to OTIO as is. OTIO reads timecodes at SMPTE rates only, and a production at an NTSC rate stores it rounded: 29.97 for 30000/1001, 23.976 or 23.98 for 24000/1001, 59.94 for 60000/1001, 47.952 for 48000/1001. Every EDL import of such a production answered a 400, "Failed to parse OTIO file: SMPTE timecode does not support this rate". - Read the EDL at the SMPTE rate within a hundredth of the production fps: at 30000/1001, non-drop-frame timecodes count 30 frames a second, and drop-frame ones (with ';') skip their frame numbers - At 29.97 and 59.94 fps, refuse a drop-frame EDL whose timecodes have no ';': OTIO skips the FCM line and would read it as non-drop-frame, 18 frames off every 10 minutes at 29.97 - Pass any other fps as is, 20 for instance: OTIO keeps refusing it, where the nearest SMPTE rate would count the frames at another rate Tests: test_import_edl_at_29_97_fps, test_import_edl_at_59_94_fps, test_import_edl_at_23_976_fps, test_import_edl_reads_drop_frame_timecodes_at_29_97_fps, test_import_edl_reads_drop_frame_timecodes_at_59_94_fps, test_import_edl_refuses_drop_frame_without_semicolons, test_import_edl_refuses_a_rate_far_from_every_timecode_rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Failed to parse OTIO file: SMPTE timecode does not support this rate;is read as non-drop-frame, 18 frames off every 10 minutes at 29.97 fpsSolution
get_timecode_rate): at 30000/1001, non-drop-frame timecodes count 30 frames a second, and drop-frame ones (with;) skip their frame numbers;(check_drop_frame_separators)