Repository navigation
Conversation
Author
|
Withdrawn by the author. This implementation is no longer being pursued upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status\n\nDraft implementation candidate for review. This changes the proposed Zou Working File authorization contract; it is not accepted or deployed.\n\n## Changes\n\n- Require an assigned Artist for WorkingFile revision creation, binary upload, metadata edits, comments, modification-date updates, and path generation.\n- Allow reads to assigned Artists, assigned Supervisors, project Managers, and Administrators; deny Clients, Vendors, and unassigned Artists.\n- Require task or manager-scoped entity filters for generic WorkingFile listing; disable generic WorkingFile creation.\n- Reject person_id spoofing, avoid implicit Task assignment, and validate entity/task pairing to prevent cross-task IDOR.\n- Update consolidated OpenAPI descriptions and add route-level role and scope regression cases.\n\n## Verification\n\n- Ruff on modified Python files: PASS.\n- Python syntax compilation on four modified files: PASS.\n- Git diff whitespace check: PASS.\n- Full Flask route/database tests: NOT RUN locally. The test harness resets its configured database; this environment has neither project dependencies nor a disposable PostgreSQL test database.\n- Browser, Kitsu, and Production verification: NOT RUN.\n\nOwner approval of the proposed authorization policy, successful CI, and independent review are required before merge or deployment.