Repository navigation
[files] Store the content of the output files and the upload date - #1323
Merged
Merged
Conversation
Member
|
Two items to address before merging:
Minor follow-up: deleting output files (with their entity or project) leaves their content in the store. Marking |
The working files and the output files get a nullable column uploaded_at: the upload route sets it, with the size of the uploaded file. Thus a client knows which files the file store has from one list request. The output files get the same file route as the working files (/data/output-files/<id>/file, prefix output in the file store). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
size was an Integer on working_file and output_file: an upload over 2 GB stored the content, then the update failed with "integer out of range". The upload date migration turns both columns into BigInteger, as done for the attachments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frankrousseau
force-pushed
the
feature/file-transfer
branch
from
October 29, 2026 10:33
de1a813 to
daae98c
Compare
The output file routes only checked the project access, so a client or any member of the team could read or replace the content of every output file. Uploading now takes a manager of the project or an assignee of the entity, never a client. Downloading an output file or a working file takes a manager or a supervisor of the project, or an artist or a vendor with a task on the entity or on an entity the asset is cast in, as for building the scene of a shot. A client downloads neither. The output file route specs move to the blueprint spec file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frankrousseau
force-pushed
the
feature/file-transfer
branch
from
October 29, 2026 10:40
daae98c to
73776d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
GETandPOST /data/output-files/<id>/file, under theoutputprefix of the file store.uploaded_atcolumn toworking_fileandoutput_file, and turn theirsizeintoBigInteger(migration). The upload routes set both.