Repository navigation
Keep the asset list after switching production from the schedule - #2308
Merged
Merged
Conversation
The setup file loaded Vue Test Utils, with the full Vue build, its template compiler, and its server renderer, in every spec file, the node specs included, which never mount. It also loaded moment to set the locale moment already starts with. On 3 workers, the setup files now take 9 s of the summed spec time instead of 16 to 17 s, about 5% of the run.
Expand all, the export, a row being expanded, and the assignment panel kept loading after a switch to another production or episode, or after the page was left. Each step read the current production again, so the rows left loaded the assets, shots, and tasks of the new one. On the Assets page, the list was replaced by assets without tasks, once per asset row left to expand. These loads now stop at their next answer once the production or the episode changes or the page is left. An Expand all stopped that way no longer flips its button.
The schedule loads the assets without their tasks. That load replaced the list the Assets page had loaded with its tasks for the same production and episode, and the page then fetched it again. A load without tasks now takes that list, loaded or on its way. The schedule reads the episode of an asset from episode_id, as that list names it, as well as from source_id, and leaves out the assets other productions share with this one, which only that list holds.
The rows of another production or episode load collapsed, but after an Expand all the button stayed on collapse: its first click did nothing. The button now starts over with the rows of the new production or episode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution