Repository navigation
[FIX] Pin GitHub Actions to commit SHAs - #1497
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 97 97
Lines 6198 6198
Branches 798 798
=======================================
Hits 5849 5849
Misses 225 225
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
genedan
left a comment
There was a problem hiding this comment.
Could you do me a favor and add the file .github/dependabot.yml?
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"This will tell dependabot to update the workflows regularly.
Fixes #1139.
All 24
uses:lines across the 7 workflows referred to a tag or a branch. They now refer to the commit that ref points to today, so a moved or retagged ref can no longer change what runs.Two of these were branches, not tags, so they could move at any time:
pypa/gh-action-pypi-publish@release/v1, which is the PyPI publish step and currently matches therelease/v1.14branch, andmarocchino/sticky-pull-request-comment@v3, currently the same commit as v3.0.5.Checked: every workflow file still parses as YAML, every SHA exists in its own repository, and no
uses:line is left unpinned. The pull_request workflows run on this PR and exercise the new pins.pythonpublish.ymlandtype_completeness_comment.ymldo not run from a PR, so those two are only exercised the next time they trigger.I did not add a version comment next to each SHA; say if you want them.