Conversation
Fixing an issue where volumetric lights can pop out of reflections if the lights are not visible from the camera frustum
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unbounded off-screen volumetric-light processing could significantly degrade performance in large scenes.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates light culling so volumetric lights remain available for reflection rendering.
Changes:
- Exempts volumetric lights from camera-frustum culling.
| File | Description |
|---|---|
trinity/Tr2LightManager.cpp |
Adjusts volumetric-light visibility handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return; | ||
| } | ||
| if( !m_frustum.IsSphereVisible( reinterpret_cast<Vector4*>( &data.position ) ) ) | ||
| if( ( data.flags & FLAG_IS_VOLUMETRIC ) == 0 && !m_frustum.IsSphereVisible( reinterpret_cast<Vector4*>( &data.position ) ) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing an issue where volumetric lights can pop out of reflections if the lights are not visible from the camera frustum
AI assistance
None