Repository navigation
Three response fields that did not match the API - #5
Merged
Merged
Conversation
inbound retry and bypass read "queued". The endpoint answers with "requeued", so both returned false and no error, whatever actually happened. They now read the right key and also expose the "message" the response carries. The subscriber types carried a "name". The create endpoint takes an address and a status; a name is silently dropped, so the field promised something the API does not store. All three were found by calling the endpoints against a live instance; the stub fixtures asserted the shapes this SDK had invented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fields in this SDK did not match what the API actually sends or
accepts. All three were introduced in 0.2.0 and all three were found by
calling the endpoints against a live instance — the stub fixtures asserted
the shapes the SDK had invented, so they passed.
1.
queuedshould berequeuedinboundretry and bypass readqueuedfrom the response. The endpointanswers:
{"requeued": true, "message": {"id": 55, "...": "..."}}So both calls returned false and no error, whatever actually happened. Fixed,
and the
messagethe response carries is now exposed too.2. Subscribers have no name
The create endpoint deserializes
addressandstatusonly:A
namewas accepted by the HTTP layer and dropped on the floor. The typepromised something the API does not store, so it is gone.
3. The broadcast send takes no tag
POST /streams/{permalink}/campaigns— sorry,/send— deserializesfrom,subject,html_body,text_body,templateandtemplate_model. No tag. Dropped for the same reason.Verified live after the fix: a retry now reports
requeued=truewith themessage id, instead of a silent false.