Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The aliased-specifier test starts an asynchronous rejection assertion but finishes before the assertion settles.
afterEachcan then dispose its evaluation broker while the transform is still running. With terminal broker disposal, this producesEval broker has been disposedinstead of the expected missing-module error, which Jest can attribute to the following resolver test.Await the assertion so the expected rejection completes before cleanup starts.
Test plan
pnpm run prepare: 16 build tasks passed.pnpm check:all: 32 tasks passed, including tests and type checks; ESLint and dependency consistency checks passed. Testkit: 150 tests and 279 snapshots passed, 2 tests skipped.awaitpassed and exited normally in all three repeated runs on each revision.This only changes a test in the private testkit package; no release changeset is needed.