Skip to content

feat(birthdays): confetti banner for today's birthdays - #76

Merged
i-am-that-guy merged 3 commits into
mainfrom
feat/birthday-confetti-banner
Oct 26, 2026
Merged

i-am-that-guy merged 3 commits into
mainfrom
feat/birthday-confetti-banner

Conversation

@i-am-that-guy

@i-am-that-guy i-am-that-guy commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

What

Replaces the plain "Today is X's birthday" banner on /birthdays with a bigger celebration card. The rest of the page is unchanged.

  • Terracotta card with brutalist confetti along the edges that floats gently (stays still with reduced motion).
  • Tilted, overlapping avatars; members without a photo get a cream initial so they stand out on the terracotta.
  • Yellow TODAY tag, heading "It's Aarav and Priya's birthday!", subtext "Make their day with a wish 🎂".
  • Send wishes button opens the existing greeting popup (same dark brown and cream border as the old "Wish Them!" button, same behaviour: jumps to the current month, restores focus on close).
  • 4+ birthdays: shows two faces plus a "+N" tile, and the heading reads "Aarav, Priya, and N others" so both match.
  • Only shown when someone has a birthday today. No change otherwise.

Files

  • TodayBanner.jsx: new banner layout (same props, so BirthdayCalendar.jsx is untouched)
  • Confetti.jsx (new): decorative confetti pieces, aria-hidden
  • BirthdayAvatar.jsx: optional fallbackClassName to recolour the initials fallback
  • index.css: small float keyframe, gated behind prefers-reduced-motion: no-preference

Testing

  • bun run lint and bun run build pass.
  • Viewed locally against a mock API with 2 and 3 birthdays today (dark mode). Heading/avatar logic checked for 1–5 people. Light mode not yet checked visually.

Summary by CodeRabbit

  • New Features
    • Birthday banners now include festive confetti and party-themed icons, with subtle floating animation.
    • When more than three people share a birthday, the banner shows two names and an “N others” label.
    • Birthday messages and button labels have been updated, with improved layout and avatar styling across screen sizes.
    • Names are displayed using first names and correctly formatted possessives, including names ending in “s”.

Replace the plain today banner with a larger card: tilted avatars,
floating confetti, and an "It's X's birthday!" heading. Avatars
without a photo use a cream fallback so they stand out on the
terracotta card. Confetti stays still for reduced-motion users.
- Show the same people in the avatars and the heading when 4+ people
  share a birthday (two faces + "+N", "…and N others").
- Respect reduced motion for the banner's slide-in.
- Name the confetti component after its file, use clear piece keys,
  and set rotation once in CSS.
- Drop dark-mode shadow overrides that had no effect.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Deploying coc-members with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25a8c8d
Status: ✅  Deploy successful!
Preview URL: https://7d35630f.coc-members.pages.dev
Branch Preview URL: https://feat-birthday-confetti-banne.coc-members.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 467bf458-c291-4871-9891-7a3e93fd9810
Commits

Reviewing files that changed from the base of the PR and between 059faae and 25a8c8d.

Files selected for processing: 1
  • frontend/src/components/birthday/TodayBanner.jsx

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 24de248b-6de8-407f-b963-4e0d032fc11f
Commits

Reviewing files that changed from the base of the PR and between 52599be and 059faae.

Files selected for processing: 4
  • frontend/src/components/birthday/BirthdayAvatar.jsx
  • frontend/src/components/birthday/Confetti.jsx
  • frontend/src/components/birthday/TodayBanner.jsx
  • frontend/src/index.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The birthday banner now displays up to three people, updates its birthday message and action button, and includes confetti. The change also adds a reduced-motion-aware floating animation and a class prop for avatar fallback styling.

Changes: Birthday banner

Layer / File(s) Summary
Confetti animation
frontend/src/components/birthday/Confetti.jsx, frontend/src/index.css
Adds ten decorative confetti pieces with varied shapes, positions, and rotations. The bday-float animation respects the reduced-motion setting.
Banner content and layout
frontend/src/components/birthday/BirthdayAvatar.jsx, frontend/src/components/birthday/TodayBanner.jsx
Adds first-name and possessive formatting, limits displayed names and avatars, and shows a count for additional members. Updates the banner structure, message, button, and responsive styling. Adds fallbackClassName to BirthdayAvatar for fallback styling.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related PRs

Suggested reviewers: sherin-2711

Merge Risk: Minimal · up to 059fa

The birthday banner change is ready to merge after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding a confetti banner for birthdays occurring today.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i-am-that-guy
i-am-that-guy merged commit 2523001 into main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant