Repository navigation
feat(birthdays): confetti banner for today's birthdays - #76
Conversation
Replace the plain today banner with a larger card: tilted avatars, floating confetti, and an "It's X's birthday!" heading. Avatars without a photo use a cream fallback so they stand out on the terracotta card. Confetti stays still for reduced-motion users.
- Show the same people in the avatars and the heading when 4+ people share a birthday (two faces + "+N", "…and N others"). - Respect reduced motion for the banner's slide-in. - Name the confetti component after its file, use clear piece keys, and set rotation once in CSS. - Drop dark-mode shadow overrides that had no effect.
Deploying coc-members with
|
| Latest commit: |
25a8c8d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d35630f.coc-members.pages.dev |
| Branch Preview URL: | https://feat-birthday-confetti-banne.coc-members.pages.dev |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Confetti animation frontend/src/components/birthday/Confetti.jsx, frontend/src/index.css |
Adds ten decorative confetti pieces with varied shapes, positions, and rotations. The bday-float animation respects the reduced-motion setting. |
Banner content and layout frontend/src/components/birthday/BirthdayAvatar.jsx, frontend/src/components/birthday/TodayBanner.jsx |
Adds first-name and possessive formatting, limits displayed names and avatars, and shows a count for additional members. Updates the banner structure, message, button, and responsive styling. Adds fallbackClassName to BirthdayAvatar for fallback styling. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- call-0f-code/COC-Members#74: Adds the initial
BirthdayAvatarandTodayBannerimplementations that this change updates. - call-0f-code/COC-Members#70: Introduces the birthday page and initial
TodayBannerfor today’s birthdays.
Suggested reviewers: sherin-2711
Merge Risk: 
Minimal · up to 059fa
-
The birthday banner change is ready to merge after normal checks.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
What
Replaces the plain "Today is X's birthday" banner on
/birthdayswith a bigger celebration card. The rest of the page is unchanged.Files
TodayBanner.jsx: new banner layout (same props, soBirthdayCalendar.jsxis untouched)Confetti.jsx(new): decorative confetti pieces,aria-hiddenBirthdayAvatar.jsx: optionalfallbackClassNameto recolour the initials fallbackindex.css: small float keyframe, gated behindprefers-reduced-motion: no-preferenceTesting
bun run lintandbun run buildpass.Summary by CodeRabbit