Repository navigation
chore(security): run CI on Node 24.22.1 and bump sharp to 0.35.5 - #1281
Conversation
Workers Builds still cannot install 24.22.1, so .nvmrc stays 24.18.0. Pin CI and release workflows to the patched runtime until that changes.
Raise the published range so installs leave 0.35.3 and 0.35.4 behind.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: f02b3a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GitHub Actions was installing Node 24.18.0 from
.nvmrc, which misses the October 2026 security release. The published CLI was also still resolvingsharp0.35.3.What it does
NODE_VERSIONenv per workflow..nvmrcstays24.18.0until Workers Builds can install 24.22.1 (#1256). Zach Dunn (@zachdunn), switch those steps back tonode-version-file: .nvmrcwhen that lands.@buildinternet/uploadsrequiressharp^0.35.5. The lockfile no longer contains 0.35.3 or 0.35.4. A patch changeset publishes that floor.What it is not
.nvmrcis untouched.Advisories
Test plan
pnpm check(oxlint and format; oxlint needed the CLI build and Astro content types, same as CI)pnpm changeset:lintpnpm --filter @buildinternet/uploads test— 89 files, 1621 tests passedpnpm why sharpreports only 0.35.5