Skip to content

feat(github): show imported GitHub attachments in the managed comment - #1269

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-u2zd46
Oct 22, 2026
Merged

Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-u2zd46

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Requested by Zach · project thread

Why

The managed comment should be the authoritative bundle of a PR's visuals, not necessarily the only place they appear. Until now, images and video imported from the PR body or comments were index-only by design (spec 2026-08-11). A PR whose screenshots were all dragged in on GitHub, like sunny-sdk/sunny#3332, therefore never got a comment. Imports now render in the comment and count toward the check, even when the same images are inline in the description.

What

  • gatherAttachments also lists each target's import folders: gh/<owner>-<name>/<kind>-<num>/, plus gh/private/<id>/ingest/<kind>-<num>/ for the private prefixes it already lists. Imports go through the existing detach filter (an image removed from the body has gh.detached=true) and hold filter. They're left out of the attachment-index shadow compare, since that index tracks managed attachments only.
  • The webhook re-syncs the comment and check after ingest instead of before. This also happens on PR open, where promote synced before ingest ran.
  • The import setting description, the GitHub App docs, the uploads ingest help and skills, and the spec note now say imports appear in the comment.

Comment sync now makes one extra R2 list per prefix (still bounded per #934). Issue-target imports show up on the next comment sync, since ingest re-syncs pull requests only, as before.

Tests


Generated by Claude Code

The managed comment is the full bundle of a PR's visuals, so attachments
imported from the PR body or comments now render in it and count toward
the check, even though they also appear inline. Comment sync lists each
target's import folders next to its attachment prefixes, and the webhook
re-syncs the comment after an import (also on PR open, where promote ran
before ingest). The import setting, docs and CLI help say so.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012CvhtYD1ej6agd8LiARpXp
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4016d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@buildinternet/uploads Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zachdunn Zach Dunn (zachdunn) self-assigned this Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed): 1
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 70cfca37-2000-4b6b-bbab-67541a9e2866

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zachdunn
Zach Dunn (zachdunn) merged commit 031fcee into main Oct 22, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/project-thread-u2zd46 branch October 22, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants