Repository navigation
feat(github): show imported GitHub attachments in the managed comment - #1269
Conversation
The managed comment is the full bundle of a PR's visuals, so attachments imported from the PR body or comments now render in it and count toward the check, even though they also appear inline. Comment sync lists each target's import folders next to its attachment prefixes, and the webhook re-syncs the comment after an import (also on PR open, where promote ran before ingest). The import setting, docs and CLI help say so. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012CvhtYD1ej6agd8LiARpXp
🦋 Changeset detectedLatest commit: 4016d55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Requested by Zach · project thread
Why
The managed comment should be the authoritative bundle of a PR's visuals, not necessarily the only place they appear. Until now, images and video imported from the PR body or comments were index-only by design (spec 2026-08-11). A PR whose screenshots were all dragged in on GitHub, like sunny-sdk/sunny#3332, therefore never got a comment. Imports now render in the comment and count toward the check, even when the same images are inline in the description.
What
gatherAttachmentsalso lists each target's import folders:gh/<owner>-<name>/<kind>-<num>/, plusgh/private/<id>/ingest/<kind>-<num>/for the private prefixes it already lists. Imports go through the existing detach filter (an image removed from the body hasgh.detached=true) and hold filter. They're left out of the attachment-index shadow compare, since that index tracks managed attachments only.uploads ingesthelp and skills, and the spec note now say imports appear in the comment.Comment sync now makes one extra R2 list per prefix (still bounded per #934). Issue-target imports show up on the next comment sync, since ingest re-syncs pull requests only, as before.
Tests
gatherCommentBodytest: plain and private imports render and count, and a detached import doesn't.apps/apivitest: 3502 passed.packages/uploads: 1621 passed.pnpm typecheck,plugin-skills:checkand prettier pass.Generated by Claude Code