Repository navigation
fix(ci): pin Node.js to 22.23.4 - #50
Merged
Merged
Conversation
actions/setup-node with node-version 22 and no check-latest can reuse an older cached 22.x. 22.23.4 is the first 22.x release that distrusts the compromised eMudhra intermediates (CVE-2026-111943). Co-authored-by: Zach Dunn <zachdunn@users.noreply.github.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Both
actions/setup-nodesteps in.github/workflows/ci.ymlpinnode-versionto22.23.4.package.jsonengines stays>=22, and the README andSKILL.mdstill say Node 22.Why
The eMudhra intermediate certificates were compromised (CVE-2026-111943, Cloudflare). Node 22.23.4 is the first 22.x release that distrusts those certificates.
actions/setup-node@v7withnode-version: 22and nocheck-latestcan keep an older cached 22.x, so a runner would still trust the compromised intermediates.The Workers Builds variable
NODE_VERSION, documented as22indocs/developing.md, is a Cloudflare dashboard setting. This PR does not change the deploy runtime.Checks
UnreleasedinCHANGELOG.md.node --test dev/test/*.test.mjspasses on Node 22.23.4 in CI.