Repository navigation
fix(gather): keep a --pr that a bot app opened - #48
Merged
Merged
Conversation
astral-sh/uv opens stacked PRs from app/astral-automations-bot, so --pr 22619 was dropped as a bot PR and the dossier came back empty. Named PRs now drop only for release-automation titles; PRs found by search or issue links still drop bot authors.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gather.mjs --prnow keeps a PR you name even when a bot app opened it. Only release-automation PRs (chore(release): …) still drop. PRs found by--searchor through issue links still drop when a bot opened them, and--keep-bot-prsworks as before.Why
astral-sh/uv opens its stacked PRs from
app/astral-automations-bot.isBotPrdropped any PR whose author starts withapp/, so--pr 22619came back as an empty dossier. #22593 worked because a person opened it.Testing
dev/test/gather.test.mjs: a PR opened by a bot app stays when named with--prand drops when found by--search.npm test: 124 tests pass.gather --pr 22619returns the PR.