Repository navigation
feat(site): touch interactions for phones - #46
Merged
Merged
Conversation
… post panel, tap figure notes On a phone the site relied on hover in three places, and two layouts cut off on narrow screens. - Hero: a sideways drag takes the table with the finger and lets go onto the nearest example, or the next on a flick. It wraps from the first back to the last. Vertical page scrolling is untouched (touch-action: pan-y). - Post panel: on touch screens it is a scroll box that opens at the first figure and drifts down the post once in view, until a finger takes over. Captions say tap instead of point. - Figure notes (template): a tap keeps a note lit, and a hotspot's tip open, until the next tap. Before, pointerleave cleared it as soon as the finger lifted. Posts made from the template get this too. - Commands wrap on phones instead of scrolling out of their box; the install command breaks after buildinternet/. - The pipeline drawing fades at its right edge while there is more to scroll. - Examples page: one-column pictures show whole instead of cropped to 4:3.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
5 files · View all on uploads.sh → Maintained by uploads.sh · add media: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





On a phone the site relied on hover in three places, and two layouts cut off on narrow screens. This makes each one work by touch.
What changes
touch-action: pan-y).buildinternet/, and the site test now allows that break point.Desktop with a mouse is unchanged, apart from the hero now also responding to a drag.
Screenshots (390 px)
Testing
npm testpasses (123 tests).hover: none, so the touch-only code was tested by forcing that media query on.