Repository navigation
feat(site): video chapters with a chapter scrubber, and a sitemap - #44
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
4 files · View all on uploads.sh → Maintained by uploads.sh · add media: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What this changes
Chapters in video exports.
motion.mjs --mp4 | --webmnow writes one chapter per scene into the file, named by the scene'slabel(or its headline if it has none). Consecutive scenes with the same label count as one chapter. It also writes<story>-motion.vttbeside the video with the same chapters. QuickTime, VLC and IINA list the embedded chapters.export.mjstakes them as--chapters <file.json>. Single-scene clips and GIFs get no chapters.The three example videos were remuxed (stream copy, no re-render) to carry their chapters. Each also gets a committed
motion.vtt.The site's player. Browsers' own video controls don't show chapters, whether from the MP4 or a
<track kind="chapters">, and they can't be restyled into segments. The example pages now have their own controls:The chapters are also listed under the player, with the current one highlighted. The video still carries a
<track kind="chapters">.Sitemap. When built with
--url, as the deploy is, the site build writessitemap.xmland arobots.txtthat points to it. The sitemap lists the home page, the examples page, and each example with its slides. A build without--urlwrites neither, because a sitemap needs absolute URLs..gitattributes:*.sh text eol=lf.Why
The cuts are already built as chapters (the scene labels read
02 · The plan in the corner). Viewers should be able to see that structure and jump to the part they want, both in the downloaded file and on the site.Checks
UnreleasedinCHANGELOG.md.node --test dev/test/*.test.mjspasses (122 tests).ffprobethat the chapters and cover art are present in exported MP4 and WebM files.