Include optional module name on file descriptor - #18
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
changed the title
In some cases, it may be useful to know the BSR module name of a file descriptor in a check plugin. This could be used to enforce package naming constraints matching the module's organization name or name. Update copyright years and buf CLI version to the latest.
pkwarren
force-pushed
the
pkw/module-name
branch
from
October 2, 2026 16:10
d4aaa1a to
c76538d
Compare
pkwarren
commented
Oct 2, 2026
| uses: actions/setup-go@v7 | ||
| with: | ||
| go-version: 1.23.x | ||
| go-version: 1.27.x |
Member
Author
There was a problem hiding this comment.
Needed >= 1.26.7 to install the latest CLI.
| (buf.validate.field).ignore = IGNORE_IF_ZERO_VALUE, | ||
| (buf.validate.field).string.uri = true | ||
| ]; | ||
| string url = 3 [(buf.validate.field).string.uri = true]; |
Member
Author
There was a problem hiding this comment.
Fixes a lint warning w/ the latest CLI.
bufdev
approved these changes
Oct 2, 2026
emcfarlane
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, it may be useful to know the BSR module name of a file descriptor in a check plugin. This could be used to enforce package naming constraints matching the module's organization name or name.
Update copyright years and buf CLI version to the latest.