Repository navigation
fix: harden payment checks and sensitive data handling - #29
Merged
Merged
Conversation
- Require explicit paid status in the low-level payment predicate - Pass curl credentials and request bodies through escaped stdin config - Omit log bodies when masking cannot safely process them - Cover security regressions and preserve high-level success flags
- Move regression tests into the existing HTTP, model and service test files - Share the loopback fixture in unit conftest and remove standalone test modules
gentiprenaj
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the existing high-level response flags and form-verifier contract. No new dependencies or public API changes.
Evidence
After: regression tests reject unpaid statuses, real local curl requests preserve bytes without argv secrets, and masking failures omit the body.
Merge Danger
Door: two-way. Code-only changes; no migration.
Blast Radius: SDK. Low-level unpaid payment checks now return false; masked logging omits unsupported bodies. Live merchant deployments were not exercised.