percent-encode IMDS role name before building credentials url - #3759
Open
ubeddulla wants to merge 1 commit into
Open
percent-encode IMDS role name before building credentials url#3759ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstanceMetadataFetcher._get_credentials appends the role name straight onto the security-credentials path, and that role name is the raw response body returned by _get_iam_role over IMDS, so a value containing separators like
../,?or#rewrites which resource the credentials request lands on. I ran a small fetcher test with a role-name body of../../../../latest/meta-data/iam/infoand the credentials GET went to.../security-credentials/../../../../latest/meta-data/iam/info. Encoding the segment with quote and a safe set of the characters legal in an IAM role name keeps valid names byte-identical while neutralizing the separators.