Generate pybind declarations before bindings - #205
Merged
Conversation
dellaert
approved these changes
Aug 23, 2026
dellaert
left a comment
Member
There was a problem hiding this comment.
Did you test it with GTSAM locally? I’d not merge until that works :-)
Collaborator
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
pybind11 constructs callable signatures when bindings are created. If a referenced wrapped type is declared by a later interface file, the signature can retain a raw C++ type name. Module-wide declare-then-bind ordering ensures all wrapped types are registered first.
Addresses borglab/gtsam#1824.
Validation