Repository navigation
Fix hang when a floating point value is too big for den_size - #720
Merged
kris-jusiak merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
expect(a == _d(1.e19))hangs (The _d() function seems to cause an infinite loop for large numbers. #711). To pick the default precision, the value constructor calls math::den_size, which multiplies by 10 and casts to unsigned long long until there's no fraction left. Past ~1.8e19 that cast is undefined and on GCC the remainder never hits zero, the loop just keeps going.Solution:
Issue: #711
Tested on Linux with GCC 14.2 and Clang 19. With just the test change ut_test hangs (killed it after 20s). With the fix everything builds, ctest passes and the post-build run of examples/benchmarks passes. Also tried the snippet from the issue.
Reviewers:
@