Repository navigation
Fix Windows CI configure on the current windows-latest image - #716
Merged
Merged
Conversation
windows-latest no longer has Visual Studio 2022, so configuring with -G "Visual Studio 17 2022" fails before anything is built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows and Windows_shared workflows fail on master and on every pull request at the configure step:
The
windows-latestimage no longer ships Visual Studio 2022. This drops the hardcoded-G "Visual Studio 17 2022"and keeps-T ${{matrix.toolset}}, so CMake uses the installed Visual Studio generator (currentlyVisual Studio 18 2026).On my fork, both workflows pass with this change for the
v143andClangCltoolsets, and ctest reports all tests passed.