Repository navigation
merge: reconcile upstream through 5da4a41d - #499
Conversation
…'s answer (colbymchenry#2557) codegraph_explore's low-value check (the hard filter, the rank penalty and the comparator key) and the dominant-file, route-file and routing-manifest filter in db/queries.ts each kept a regex list of their own. They missed every test convention isTestFile learned since: C++ `foo_test.cc` and `FooTest.cpp`, Google's `foo_unittest.cc`, LLVM's `unittests/`, `testing/`, `e2e/`, `__mocks__/`, Gradle `foo-test/` modules, Kotlin source sets, and the examples, samples, fixtures and benchmarks that explore's gather already dampens through isTestFile. Both now build on isTestFile, keeping icons/i18n (explore) and generated files (queries), plus the singular `__test__/` the old lists matched. Dropping their lowercase suffix patterns also ends false positives such as `Latest.java` and `contest.cs`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/db/queries.ts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check | Check skipped - CodeRabbit’s high-level summary is enabled. | |
| Title check | The title clearly identifies the primary change: merging upstream through commit 5da4a41. It is concise and specific. | |
| Linked Issues check | Check skipped because no linked issues were found for this pull request. | |
| Out of Scope Changes check | Check skipped because no linked issues were found for this pull request. | |
| Suppressions Explained | PASS. The pull request changes five files and adds no lint, type-check, or compiler suppression directive. The added comments describe test-file filtering, not diagnostic suppression. No lint or TypeS… | |
| User-Visible Changes Documented | The pull request changes test/example file classification in src/db/queries.ts and src/mcp/tools.ts, adds integration tests, and updates CHANGELOG.md plus the fork commit reference in `README.md… |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 LanguageTool
-
CHANGELOG.md
-
LanguageTool checks are incomplete because the per-file request limit of 5 was reached. Remaining text was skipped; findings from completed checks are retained.
-
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
fork/consolidatednow contains upstreammainthrough5da4a41d(one commit, colbymchenry#2557), socodegraph_explorestops listing tests, examples and fixtures that the engine already treats as test files.The upstream commit makes explore's low-value check and the dominant-file filter in
src/db/queries.tsbuild onisTestFile, which closes gaps such as C++foo_test.ccandFooTest.cpp,unittests/,__mocks__/and Gradlefoo-test/modules, and ends false positives such asLatest.java.Conflict. One, in the import line of
src/db/queries.ts: the fork importsgetStemVariants, upstream importsisTestFile. The merged line imports both; nothing else needed a decision. The merge is a true merge commit (landed withmerge-pr.sh --merge) so upstream's commit stays an ancestor.Checks, on this head. Full suite 721 files / 9065 tests pass, including upstream's new
__tests__/explore-low-value-tests.test.ts;tsc --noEmitandcheck:agent-docsare clean. The kernel sources are unchanged, so no golden or precision run applies.README. The "About this fork" merge-point paragraph now names
5da4a41d. No other row, and no number the README quotes, changed.Not covered: promoting the deployed build.
Summary by cubic
Reconciles
fork/consolidatedwith upstream through5da4a41d, socodegraph_exploreand the dominant-file filter now rely on the engine'sisTestFilecheck instead of separate regex lists. Explore no longer lists tests, examples, fixtures, or benchmarks that the engine already considers test files, covering C++foo_test.cc/FooTest.cpp,unittests/,e2e/, and Gradlefoo-test/modules, and ends false positives likeLatest.java.src/db/queries.tsby importing bothgetStemVariantsandisTestFile.5da4a41d. Full suite (9065 tests) passes; no re-index needed.Written for commit 789f257. Summary will update on new commits.
Summary by CodeRabbit