Reject partial database size results - #185
Open
eduardo-landin-mestre wants to merge 1 commit into
Open
eduardo-landin-mestre wants to merge 1 commit into
eduardo-landin-mestre wants to merge 1 commit into
Conversation
eduardo-landin-mestre
marked this pull request as ready for review
September 17, 2026 19:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
size.databasecollector does not check for errors reported after row iteration. If a query returns some rows and then fails, Blip reports the partial values as a successful database-size snapshot.What?
Check
rows.Err()before calculating totals or returning metrics. A fault-injection test verifies that the collector returns the stream error and discards partial values.Testing
Started MySQL 8.0 and 8.4 with
docker compose -f test/docker/docker-compose.yaml up -d, then rango test ./.... The full suite passed.