Skip to content

TODO: remove the finished ArchUnit item, correct stale facts - #406

Merged
bernardladenthin merged 1 commit into
mainfrom
chore/todo-cleanup
Oct 28, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
chore/todo-cleanup

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

TODO cleanup: finished items are deleted (the file's own rule), partly finished ones keep only what is open, stale facts are corrected. Every change was checked against the code, a merged PR or a CI run; the commit message lists the evidence per item.

  • Removed: "Additional ArchUnit rules" (the item says all DONE).
  • Corrected: claude-review now points to crossrepostatus.md; the SpotBugs trigger (PR #4087 closed unmerged, issue #3918 open); PIT list (16 classes incl. Hash160); @VisibleForTesting (80 sites, re-audit); OPM dangling reference.

Test plan

  • Each removal verified against its evidence (listed in the commit message)
  • Docs-only change (TODO.md)

Related issues / PRs

Part of a cleanup across the four repositories, workspace (e2197bd) and workspacePrivate.

Checklist

  • No code change
  • Nothing open was dropped: partly done items keep their open part

🤖 Generated with Claude Code

https://claude.ai/code/session_01DuAkLtHrCTx81vP5Mt4jad

- "Additional ArchUnit rules": the item itself says all DONE; the rules
  are in BitcoinAddressFinderArchitectureTest.
- claude-review: tracked once for all four repos in crossrepostatus.md.
- SpotBugs THROWS_METHOD_THROWS_RUNTIMEEXCEPTION: PR #4087 was closed
  unmerged on 2026-06-23, so the trigger is a release fixing #3918.
- PIT: the gate lists 16 classes, model.Hash160 included.
- @VisibleForTesting: 80 annotated sites in src/main, not 10; the old
  verdict is outdated, re-audit.
- OPM: drop the pointer to a "Done" history that does not exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuAkLtHrCTx81vP5Mt4jad
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bernardladenthin
bernardladenthin merged commit 58088ce into main Oct 28, 2026
10 of 13 checks passed
@bernardladenthin
bernardladenthin deleted the chore/todo-cleanup branch October 28, 2026 17:01
@sonarqubecloud

Copy link
Copy Markdown

This branch was successfully deployed

No deployments
startgate — 4c11a327 Deployed Oct 28, 2026 by bernardladenthin via Start gate (abort window) #590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant