Repository navigation
crate_universe: skip root MODULE.bazel lookup for non-root modules - #4386
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
Fixes bazelbuild#4385 Assisted-by: Claude
This was referenced Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4385.
crate_universeno longer looks up@@//:MODULE.bazelfor non-root modules, so a root module without a top levelBUILD.bazelcan depend on a module that usescrate.from_cargo.crate_universe/extensions.bzl: look up the root only whenis_root, else usetag_path. The value only filters watched paths when not repinning.crate_universe/tests/integration/non_root_no_root_buildwith no rootBUILD.bazel, depending oncargo_aliases. It fails with "BUILD file not found" without the change.cargo_aliases: make:aliasespublic. Add CI jobs for the new fixture.bazel test //...in the new fixture passes. buildifier and the existingcargo_aliasesjob were not run locally.Assisted-by: Claude
Assisted by Claude.